Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor #1

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

Refactor #1

wants to merge 13 commits into from

Conversation

kevinbtai
Copy link
Collaborator

Changes

  1. Moved to use https://python-poetry.org/ dependency management
  2. Refactored code to run under backend instead of putting everything at the root django directory
  3. Moved SECRET_KEY management to be environment variable based
  4. Removed unnecessary django clover files

Ran make run-dev and played around with the game to ensure things still worked.

@kevinbtai kevinbtai requested a review from marktai July 4, 2022 08:25
marktai
marktai requested changes Jul 13, 2022
View reviewed changes
Copy link
Owner

@marktai marktai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/backend\/backend/backend\/clover/g

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marktai marktai marktai requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kevinbtai @marktai