Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #245. Remove validity interval from marlowe-cli run withdraw. #780

Merged
merged 1 commit into from
Dec 15, 2023

Conversation

bwbush
Copy link
Collaborator

@bwbush bwbush commented Dec 15, 2023

As noted in #245, marlowe-cli run withdraw erroneously includes a validity interval in the transaction. Although that was mostly harmless, it was unnecessary, so this PR removes it.

Pre-submit checklist:

  • Branch
    • Tests are provided (if possible)
    • Test report is updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
    • Relevant tickets are mentioned in commit messages
    • Formatting, PNG optimization, etc. are updated
    • Operables are updated with changes to executable command line options.
    • Deploy charts updated with changes to operables.
  • PR
    • Self-reviewed the diff
    • Useful pull request description
      • Review required
      • Substantial changes to code, test, or documentation
      • Change made to Marlowe validator (@bwbush and @palas must be included as reviewers)
      • Review not required
      • Minor changes to non-critical code, documentation, nix derivations, configuration files, or scripts
      • Formatting, spelling, grammar, or reorganization
    • Reviewer requested

@bwbush bwbush enabled auto-merge December 15, 2023 19:41
@bwbush bwbush merged commit 226a68d into main Dec 15, 2023
5 checks passed
@bwbush bwbush deleted the issue245 branch December 15, 2023 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant