Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Add WebSocket client #163

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

WIP: Add WebSocket client #163

wants to merge 8 commits into from

Conversation

maruTA-bis5
Copy link
Owner

@maruTA-bis5 maruTA-bis5 commented Feb 24, 2019 •
edited
Loading

fix #32

@maruTA-bis5 maruTA-bis5 force-pushed the 32-websocket-client branch from 2118a82 to 1b08384 Compare May 5, 2019 23:39
@laurentperez
Copy link

Hello @maruTA-bis5 . The event deserialization test looks good at https://github.com/maruTA-bis5/mattermost4j/pull/163/files#diff-5a6885b21a4e1bf932fcff303f20d94392d9132efae9c1012244344250fcd7f7

I'm not sure if there is lot of work to complete the WIP. It seems Jakarta undertow websocket does not have big breaking changes.

Should you set to Draft instead of WIP to retry the checks and show the pull conflicts ?

It would be a great feature to have the Websocket instead of polling the channels events :)

I might help with the merge if you'd like to. My TZ is GMT+1. I do not know if you plan to add more stuff to the PR or just want to merge as is ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement: WebSocket Client
2 participants
@maruTA-bis5 @laurentperez