Skip to content

Commit

Permalink
MDL-83862 question: Improve error handling of question bank filters.
Browse files Browse the repository at this point in the history
This provides better handing of errors from question bank filters
by displaying messages from thrown exceptions in an alert,
allowing the error messages to be tested for. This allows filter
conditions to perform some validation and return an error if
something is not valid.

It also moves the code updating the URL parameters to after the
filtered questions have been successfully returned, meaning that
if there is an error, the invalid values will never be set in the
URL. This avoids users accidentally sharing a URL that will always
display an error.
  • Loading branch information
marxjohnson committed Dec 10, 2024
1 parent 0871ed5 commit f701c46
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 4 deletions.
2 changes: 1 addition & 1 deletion question/amd/build/filter.min.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit f701c46

Please sign in to comment.