Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update read coins field #616

Closed
wants to merge 2 commits into from
Closed

Conversation

Ben-Rey
Copy link
Collaborator

@Ben-Rey Ben-Rey commented May 28, 2024

No description provided.

@Ben-Rey Ben-Rey changed the base branch from main to xp-new-version May 28, 2024 14:29
@Ben-Rey Ben-Rey force-pushed the update-api-read-coins branch from aa06841 to fd1e33c Compare May 28, 2024 14:36
Copy link

github-actions bot commented May 28, 2024

Coverage report for experimental massa-web3

St.
Category Percentage Covered / Total
🟢 Statements 83.81% 911/1087
🟡 Branches 73.87% 164/222
🟢 Functions 84.21% 176/209
🟢 Lines 83.96% 911/1085

Test suite run success

118 tests passing in 12 suites.

Report generated by 🧪jest coverage report action from af2a6f2

@@ -3142,7 +3142,7 @@
"type": "array",
"items": {
"format": "byte",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think "format" can be removed if type= number

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok done thanks

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Member

@thomas-senechal thomas-senechal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@Ben-Rey Ben-Rey requested a review from modship May 29, 2024 16:35
@Ben-Rey
Copy link
Collaborator Author

Ben-Rey commented May 29, 2024

This pr will wait until api is updated

@Ben-Rey Ben-Rey added the On hold label Jun 3, 2024
@Ben-Rey Ben-Rey closed this Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants