Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deferred calls #734

Merged
merged 2 commits into from
Jan 21, 2025
Merged

Deferred calls #734

merged 2 commits into from
Jan 21, 2025

Conversation

modship
Copy link
Member

@modship modship commented Jan 20, 2025

No description provided.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 20, 2025 •
edited
Loading

Coverage report for experimental massa-web3

St.❔
 Category Percentage Covered / Total
🟡 Statements
66.04% (-0.16% 🔻)
 1258/1905
🔴 Branches 43.51% 201/462
🔴 Functions
45.96% (-0.58% 🔻)
 222/483
🟡 Lines
66.61% (-0.16% 🔻)
 1251/1878
Show files with reduced coverage 🔻
St.❔
 File Statements Branches Functions Lines
🔴
... / publicAPI.ts
9.9% (-0.3% 🔻)
 2.27%
1.75% (-0.1% 🔻)
10.99% (-0.37% 🔻)
🔴
... / connector.ts
51.89% (-0.11% 🔻)
 0%
1.92% (-0.12% 🔻)
51.89% (-0.11% 🔻)

Test suite run success

134 tests passing in 15 suites.

Report generated by 🧪jest coverage report action from 0f89571

@modship modship requested a review from peterjah January 20, 2025 13:58
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@modship modship linked an issue Jan 20, 2025 that may be closed by this pull request
add deferred call endpoints #684
Closed
peterjah
peterjah approved these changes Jan 21, 2025
View reviewed changes
Copy link
Collaborator

@peterjah peterjah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gud!
A real e2e test would have been nice to have.

@modship modship merged commit 3e804d9 into main Jan 21, 2025
6 checks passed
@modship modship deleted the deferred_calls branch January 21, 2025 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterjah peterjah peterjah approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add deferred call endpoints
2 participants
@modship @peterjah