Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ada swap functionality #93

Closed
wants to merge 2 commits into from
Closed

Conversation

bytegen-dev
Copy link
Collaborator

Pull Request Template

Purpose of this Pull Request

[] Documentation update
[X] Bug fix
[X] New feature
[] Other:

Overview of Changes

Issue Addressed

Checklist

  • I have used lint and format to follow the code formatting
  • I have tested my changes locally and all of them pass
  • I have updated documentation (if applicable).

Focus for Reviewers

Copy link
Collaborator

@schaier-io schaier-io left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see the individual reviews for each file.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please us the left version

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you change the path name back to the previous one

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

now there are missing dependencies

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also some new types like swagger typescript, not sure if this is needed?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove all the old api files and use the client instead

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove all the old api files and use the client instead

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

idealy remove all any calls and use infer. Also you should not call the rpc provider yourself if not necessary. Use the backend methods instead

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if not necessary do not call the rpc provider. Use the backend methods instead

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this change seems not intended

@bytegen-dev bytegen-dev closed this Mar 3, 2025
@schaier-io schaier-io deleted the add-ada-swap-functionality branch March 3, 2025 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants