Use getCountForPagination for query count

[Jade-GG]

The count query doesn't always work properly under certain conditions, specifically a query with a GROUP BY seems to be the issue.

We can use the getCountForPagination function that laravel provides and uses internally for the pagination function. Scout itself actually also uses this function to get the count.

[matchish]

I would be cool if you add a test that fails without using getCountForPagination and pass with

[Jade-GG]

I would be cool if you add a test that fails without using getCountForPagination and pass with

I did try for a bit but couldn't really get it to work unfortunately (and I'd rather not spend too much time on tinkering with the tests at this moment). I will also say that I can't find the exact cause of the incorrect count we encountered---it has something to do with combining joins an group by and possibly also global scopes... it's a mess.

Don't know if it's really that necessary to have a test for this at the end of the day 🙂