[FloatingActionButton] Fix labelOpacity property #4594
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
Fixes an incorrect implementation of the
Property#get(Object)
method of thelabelOpacity
property:Before:
After:
Simplifies the calculation of the target color in the
Property#set(Object, Object)
method. In particular, it eliminates unnecessaryblah-blah / 255F * 255
, which only result in a loss of accuracy.Avoids calculating the target color when it's not needed.