-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pin MACE calculator version, add missing metadata to AseStructureTaskDoc #1119
Conversation
src/atomate2/forcefields/__init__.py
Outdated
@@ -12,7 +12,8 @@ | |||
class MLFF(Enum): # TODO inherit from StrEnum when 3.11+ | |||
"""Names of ML force fields.""" | |||
|
|||
MACE = "MACE" | |||
MACE = "MACE" # This is MACE-MP-0-medium | |||
MACE_MPA_0 = "MACE_MPA_0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As there are now 3 different MACE MP 0s, should we use 3b? For phonons, it is a lot better than the initial one, for example
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added 0b3 as well. Avoiding Omat for license reasons. Also added a from_force_field_name
method to the phonon and QHA makers to allow easier instantiation of these from a str
@esoteric-ephemera thank you! I am still thinking about a few points:
What do you think? |
@JaGeo these are good points, they merit some discussion. The default in I primarily want to avoid a situation where workflows aren't reproducible using the same settings. Adding a |
agreed, that sounds good 👍 |
…ACE is specified without specific version
Agreed! This sounds very good! Backward-compatibility is extremely important as well! |
@esoteric-ephemera thank you very much! This is great! I will merge! |
Fixes three issues:
AseStructureTaskDoc
andForceFieldTaskDocument
were missing some metadata fields when constructed from a relax job. These are just convenience things like number of elements, symmetry, etc. but should be populatedfrom_force_field_name
methodThe
MLFF
optionMACE
still points to MACE-MP-0, whereas specifying:MACE_MPA_0
selects MACE-MPA-0-
MACE_MP_0B3
selects MACE-MP-0b3I think we want to avoid creating an MLFF forcefield interchange library a la LibXC, so I'm happy to remove the new
MLFF
values. Also, because MACE-OMat is ASL licensed, don't want to include this as an MLFF by default