-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Aims phonon tutorials #1136
Aims phonon tutorials #1136
Conversation
Makes the tutorial between aims and Vasp the same
monkey_patch for tutorials in FHI-aims added
@JaGeo Here is the FHI-aims phonon documentation PR |
Also I think the VASP tutorial should have |
test data and the tutorial
Printing here makes sense
…2 into aims_phonon_tutorials
Settings not setup in test area
Thanks for pointing this out. Will check again and potentially fix it. Overall: thank you very much for the tutorial This is very helpful! |
Summary
Include a summary of major changes in bullet points:
Work-in-progress pull requests are encouraged, but please put [WIP] in the pull request
title.
Before a pull request can be merged, the following items must be checked:
The easiest way to handle this is to run the following in the correct sequence on
your local machine. Start with running
ruff
andruff format
on your new code. This willautomatically reformat your code to PEP8 conventions and fix many linting issues.
Run ruff on your code.
type check your code.
Note that the CI system will run all the above checks. But it will be much more
efficient if you already fix most errors prior to submitting the PR. It is highly
recommended that you use the pre-commit hook provided in the repository. Simply run
pre-commit install
and a check will be run prior to allowing commits.