[WIP] Base pymatgen objects, Computed{Structure}Entry pydantic models#1431
Open
esoteric-ephemera wants to merge 7 commits into
Open
[WIP] Base pymatgen objects, Computed{Structure}Entry pydantic models#1431esoteric-ephemera wants to merge 7 commits into
esoteric-ephemera wants to merge 7 commits into
Conversation
a390bfa to
2fb2508
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1431 +/- ##
============================================
- Coverage 85.40% 72.93% -12.47%
============================================
Files 230 156 -74
Lines 18667 13379 -5288
============================================
- Hits 15942 9758 -6184
- Misses 2725 3621 +896 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For these more in-depth objects, functionality is there to get critical features from
Materialwithout going into the pymatgen object: