Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sc back #171

Merged
merged 17 commits into from
Feb 23, 2024
Merged

Sc back #171

merged 17 commits into from
Feb 23, 2024

Conversation

jmmshn
Copy link
Collaborator

@jmmshn jmmshn commented Feb 23, 2024

Get Supercell LOCPOT from unit cell

  • Import pyrho for grid transformations
  • Updated get_matched_structure_mapping to use the sm.get_transformation(s1, s2) API
  • Added get_closest_sc_mat function which will give a best guess for the bulk SC that maches the defect SC based on the bulk UC structure.
  • Added get_sc_locpot which returns a bulk SC locpot that matches some desired defect SC data.

Copy link

codecov bot commented Feb 23, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 90.35%. Comparing base (f329d9d) to head (2f415ce).

Files Patch % Lines
pymatgen/analysis/defects/supercells.py 90.00% 1 Missing and 3 partials ⚠️
pymatgen/analysis/defects/thermo.py 60.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #171      +/-   ##
==========================================
- Coverage   90.67%   90.35%   -0.32%     
==========================================
  Files          11       11              
  Lines        2070     2116      +46     
  Branches      400      407       +7     
==========================================
+ Hits         1877     1912      +35     
- Misses        106      117      +11     
  Partials       87       87              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jmmshn jmmshn merged commit 9a728db into main Feb 23, 2024
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant