Js runs

[jmmshn]

[BUGFIX] Serialization bug

user_charges is not respected after deserialization.

Monty's as_dict and from_dict do not read the parents __init__ so passing kwargs up does not work.

We have to explicitly pass the parameters down:

from monty.json import MSONable

class A(MSONable):
    def __init__(self, v1 = 1):
        self.v1 = v1
        
class B(A):
    def __init__(self, v2, **kwargs):
        self.v2 = v2
        super().__init__(**kwargs)
        
b = B(v2=2)
print(b.as_dict()) # does not contain v1

A nicer solution will be to fix the behavior in Monty and combine arguments from the full __mro__

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.90%. Comparing base (c788e64) to head (9c3a1bd).

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #187   +/-   ##
=======================================
  Coverage   90.90%   90.90%           
=======================================
  Files          11       11           
  Lines        2111     2111           
  Branches      393      393           
=======================================
  Hits         1919     1919           
  Misses        111      111           
  Partials       81       81           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.