Revert breaking analysis.local_env default_op_params/cn_opt_params rename
#4151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielYang59
force-pushed
the
fix-local_env-rename
branch
from
45d308e to
4563dee
Compare
DanielYang59
changed the title
analysis.local_env default_op_params/cn_opt_params renameanalysis.local_env default_op_params/cn_opt_params rename
DanielYang59
commented
Nov 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
analysis.local_envdefault_op_params/cn_opt_paramsrename, reported in Fix compatibility with newpymatgenpymatgen-analysis-defects#206 and Bump pymatgen from 2024.10.3 to 2024.10.27 atomate2#1030