-
Notifications
You must be signed in to change notification settings - Fork 31
Add AdsorptionCalc Class for Adsorption Energy Calculation
#118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
AdsorptionCalc Class for Adsorption Energy Calculation
|
@rul048 Seems tests are failing due to other parts of the code that I probably shouldn't modify. Please advise. Note that I also bumped pyright to pyright==1.1.407 due to a known error in pyright==1.1.406 in pyproject.toml. |
Signed-off-by: Runze Liu <[email protected]>
Signed-off-by: Runze Liu <[email protected]>
Updated workflow triggers and comments in test-nbs.yml. Signed-off-by: Runze Liu <[email protected]>
|
All lints and tests for For the first issue, I will remove the example notebook from this PR and upload it by myself. For the second issue, I will set the backend to DGL for each notebook. |
AdsorptionCalc Class for Adsorption Energy CalculationAdsorptionCalc Class for Adsorption Energy Calculation
Summary
This PR introduces the AdsorptionCalc class for single molecule adsorption calculations on surfaces. It supports:
Key Features
Todos
Some tests not related to AdsorptionCalc need to be fixed
Checklist
ruff.mypy.duecredit@due.dcitedecorators to reference relevant papers by DOI (example)