Use destruct method to flush the producer

[sash]

I had issues with the new async producer. Because the reference is captured in the terminate callback, in fact the rdkafka producer is never garbage collcted and because of that in the queue the connection to kafka is never terminated.

That causes issue when used in the queue as new connections indeed created, but the old ones are never closed.

The solution would be to use the destructor. In that way - if you use the main facade method - the reference is kept around for a second publish, and if you do Kafka::fresh(), the message will be flushed when it foes out of scope and then when it is destroyed the connection is closed too. That works great for the Queue because the Facade cache is reset after each job execution! If someone wants to implement a persistent publisher that works cross-jobs - he can create a singleton!

[mateusjunges]

@sash can you take a look at the test failures please?

[mateusjunges]

and sorry for the delay on checking this, but GitHub is not notifying me for some reason

[mateusjunges]

have been testing this since yesterday but I have no idea how to fix the test suite as the __destruct method won't be called. If I recall correctly, PHPUnit only releases the mock references after the test completes, at which point the __destruct method is called, making it difficult to test this behavior during the test run. Any suggestions?

[sash]

Perhaps the method can be move away from the destruct and can be called by hand in the test to simulate the garbage collection in the test? Its not pretty but I dont know what else can be done