Add PERMISSION_READ_HEALTH_DATA_IN_BACKGROUND #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@matinzd Please review when you have time 🙏 |
matinzd
requested changes
Feb 11, 2025
| @@ -331,6 +335,7 @@ export interface PowerRecord extends IntervalRecord { | |||
| } | |||
|
|
|||
| export type HealthConnectRecord = | |||
| | PermissionReadHealthDataInBackground | |||
There was a problem hiding this comment.
This should not be a part of HealthConnectRecord because when you are reading or writing into it, you'll get the suggestion for the permission as well which is not a health record. Please consider making a separate function or move it to requestPermission type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @matinzd,
This is my first time contributing to a GitHub projects, and I appreciate the opportunity! I’ve made some changes to enable PERMISSION_READ_HEALTH_DATA_IN_BACKGROUND, and I hope it aligns with the project's goals. Please let me know if there are any improvements or changes needed.
Thank you for your time and for maintaining this great project! 🚀