Fix function call #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vpapanasta
reviewed
Apr 22, 2024
| if ~endsWith(s.name, ".png") | ||
| imgDetails = imfinfo(filePath); | ||
| imgFormat = imgDetails.Format; | ||
| if ~(imgFormat=="png") |
There was a problem hiding this comment.
How come do we accept only "png"? Is it a requirement from the OpenAI API?
There was a problem hiding this comment.
Yes, that restriction comes from the OpenAI side. We might later want to add a test to make sure this behavior not changing.
|
The example works for me. The .csv file is being generated as expected. |
vpapanasta
reviewed
Apr 22, 2024
| @@ -86,7 +86,7 @@ | |||
|
|
|||
| arguments | |||
| this (1,1) openAIImages | |||
There was a problem hiding this comment.
openAIImages is not perfectly aligned. Just delete a space before it.
vpapanasta
approved these changes
Apr 22, 2024
This was referenced Apr 22, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing broken function call examples