Skip to content

Flake8 cleanup #625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

Conversation

Cdiaz1234
Copy link

This PR resolves Issue #528 by cleaning up solar.py to comply with flake8 standards.

  • Fixed E501 (line too long), E302 (expected blank lines), E231 (missing whitespace), and more
  • Ran flake8 to verify all errors are cleared

No functionality was changed — this is a pure style/lint cleanup.

@DWesl
Copy link
Contributor

DWesl commented May 6, 2025

It looks like the first three commits are for a shiftdata fix you were preparing a month ago: it might be simplest to copy Downloads/.../solar.py somewhere, revert that commit, turn this PR into the shiftdata PR you were preparing, run git checkout upstream/develop -b flake8-solar-cleanup, copy solar.py back to packages/basemap/src/mpl_toolkits/basemap/solar.py, and open a new PR to be the "get flake8 to pipe down about solar.py" one

@DWesl
Copy link
Contributor

DWesl commented May 7, 2025

Alternately, you might be able to do

cd /path/to/basemap-repository/Downloads/basemap-develop/
git init
git remote add upstream https://github.com/matplotlib/basemap
git fetch upstream
git remote add origin [email protected]:Cdiaz1234/basemap
git fetch origin
git branch flake8-develop
cd packages/basemap/
git add src/mpl_toolkits/basemap/{__init__,solar}.py
git commit
git push --set-upstream --force origin flake8-develop

to turn the unpacked ZIP archive of the repository's develop branch into its own git repository

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants