Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix black action arguments + formatting #9

Merged
merged 3 commits into from
May 25, 2022
Merged

Conversation

oscargus
Copy link
Member

@oscargus oscargus commented May 1, 2022

Seems like black has changed the argument handling. I got this on my newly create repo:

Warning: Unexpected input(s) 'args', valid inputs are ['options', 'src', 'black_args', 'version']

https://black.readthedocs.io/en/stable/integrations/github_actions.html gives the changes in this PR. src is not really required since . is the default, but I included it for clarity in case someone want to change it later.

The second commit fixes two issues that black points out in the generated code.

Edit: third commit fixes doc formatting.

Let me know if I should squash these into a single commit. Updating as I go along making my project pass the tests with the default setup.

@ianhi
Copy link
Collaborator

ianhi commented May 1, 2022

This is great thanks!

Also in #8 I've added a pre-commit config which could obsolete the lint action. what do you think?

@ianhi
Copy link
Collaborator

ianhi commented May 1, 2022

Let me know if I should squash these into a single commit. Updating as I go along making my project pass the tests with the default setup.

These are distinct changes so let's not do that.

@oscargus
Copy link
Member Author

oscargus commented May 7, 2022

Probably not experienced enough to have strong opinions on this.

Regarding pre-commit I personally have some issues running it on Windows due to being too lazy to set it up properly (develop using conda, but doing git using the bash-prompt from Git for Windows, so they do not have the same Python environments). Running it on the CI is a different thing though.

@ianhi
Copy link
Collaborator

ianhi commented May 25, 2022

sorry this dropped off my radar. looks good thanks!

@ianhi ianhi merged commit 9348637 into matplotlib:main May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants