Skip to content

Add inheritance graphs to docs #171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 15, 2023
Merged

Conversation

dstansby
Copy link
Member

Fixes #169. Here's what it looks like rendered locally for me:

Screenshot 2023-06-15 at 10 01 01

@dstansby dstansby changed the title Inheritance graphs Add inheritance graphs to docs Jun 15, 2023
@samcunliffe
Copy link
Collaborator

samcunliffe commented Jun 15, 2023

Yeah, do you think it's worthwhile?
Since #168 there is now some relatively interesting class structure.

Also: custom plot users will need to inherit from... SingleAxisWidget now, right?

@dstansby
Copy link
Member Author

I think it's worth it, especially if #167 happens and it gets even more interesting

@dstansby dstansby requested a review from samcunliffe June 15, 2023 09:35
Co-authored-by: Sam Cunliffe <[email protected]>
@dstansby dstansby enabled auto-merge June 15, 2023 09:38
@samcunliffe
Copy link
Collaborator

Do we need @ruaridhg because: co-authored commit?

@dstansby
Copy link
Member Author

I think I hit the merge buton, it's just waiting for tests.

@dstansby
Copy link
Member Author

@samcunliffe can you try giving this a fresh approve?

@dstansby dstansby added this pull request to the merge queue Jun 15, 2023
Merged via the queue into matplotlib:main with commit e6446fc Jun 15, 2023
@ruaridhg
Copy link
Collaborator

Diagram looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add inheritance graphs to docs
3 participants