Switch sliding sync support to simplified sliding sync by dbkr · Pull Request #4400 · matrix-org/matrix-js-sdk

dbkr · 2024-09-12T13:38:08Z

Switches js-sdk's sliding sync support to simplified sliding sync. This is still experimental.

This does not maintain support for regular sliding sync.

Checklist

Tests written for new code (and old code if feasible).
New or updated public/exported symbols have accurate TSDoc documentation.
Linter and other CI checks pass.
Sign-off given on the changes (see CONTRIBUTING.md).

Experimental PR to test js-sdk with simlified sliding sync. This does not maintain support for regulaer sliding sync.

Working branch to get SSS functional on element-web. Requires matrix-org/matrix-js-sdk#4400

DoM1niC · 2024-09-13T17:47:37Z

@dbkr loading DMs names are fixed for me but Avatars don't load inital only when I click on a DM (Room) and the Timeline shows only one recent Message, like this

after I reopen the Room the History will partially load....

Otherwise when the room next appears the name/avatar reset to 'Empty Room' with no avatar.

SSS doesn't have them.

richvdh

A few nits but generally lgtm

src/models/room-summary.ts

src/models/room.ts

richvdh · 2025-03-18T13:17:11Z

src/models/room.ts

-            // just to be sure
-            this.summaryHeroes = heroes.filter((userId) => {
-                return userId !== this.myUserId;
+        if (Array.isArray(heroes) && heroes.length > 0) {


why do we add this new heroes.length > 0 condition? it seems wrong to me, but maybe it doesn't matter.

Mmm, I suppose this is unnecessary and might cause some situation where they aren't cleared when they ought to be.

src/models/room.ts

richvdh · 2025-03-18T13:18:23Z

src/models/room.ts

+        if (joinedCount !== undefined && Number.isInteger(joinedCount)) {
+            this.currentState.setJoinedMemberCount(joinedCount);
+        }
+        if (invitedCount !== undefined && Number.isInteger(invitedCount)) {


Typescript complains without these checks as Number.isInteger doesn't accept undefined for whatever reason.

src/models/room.ts

richvdh · 2025-03-18T13:20:38Z

src/models/room.ts

        let otherNames: string[] = [];
-        if (this.summaryHeroes) {
+        if (this.heroes) {
            // if we have a summary, the member state events should be in the room state


this comment feels like it's got a bit lost, as well

Mmm yeah, should be better now.

Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>

as it wasn't really necessary and may cause heroes not to be cleared?

Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>

as it's necessary to stop typescript complaining

dbkr · 2025-03-18T17:23:39Z

Force merging because the upstream will be incompatible

* Experimental SSS Working branch to get SSS functional on element-web. Requires matrix-org/matrix-js-sdk#4400 * Adjust tests to use new behaviour * Remove well-known proxy URL lookup; always use native This is actually required for SSS because otherwise it would use the proxy over native support. * Linting * Debug logging * Control the race condition when swapping between rooms * Dont' filter by space as synapse doesn't support it * Remove SS code related to registering lists and managing ranges - Update the spidering code to spider all the relevant lists. - Add canonical alias to the required_state to allow room name calcs to work. Room sort order is busted because we don't yet look at `bump_stamp`. * User bumpStamp if it is present * Drop initial room load from 20 per list to 10 * Half the batch size to trickle more quickly * Prettier * prettier on tests too * Remove proxy URL & unused import * Hopefully fix tests to assert what the behaviour is supposed to be * Move the singleton to the manager tyo fix import loop * Very well, code, I will remove you Why were you there in the first place? * Strip out more unused stuff * Fix playwright test Seems like this lack of order updating unless a room is selected was just always a bug with both regular and non-sliding sync. I have no idea how the test passed on develop because it won't run. * Fix test to do maybe what it was supposed to do... possibly? * Remove test for old pre-simplified sliding sync behaviour * Unused import * Remove sliding sync proxy & test I was wrong about what this test was asserting, it was suposed to assert that notification dots aren't shown (because SS didn't support them somehow I guess) but they are fine in SSS so the test is just no longer relevant. * Remove now pointless credentials * Remove subscription removal as SSS doesn't do that * Update tests * add test * Switch to new labs flag & break if old labs flag is enabled * Remove unused import & fix test * Fix other test * Remove name & description from old labs flag as they're not displayed anywhere so not useful * Remove old sliding sync option by making it not a feature * Add back unread nindicator test but inverted and minus the bit about disabling notification which surely would have defeated the original point anyway? * Reinstate test for room_subscriptions ...and also make tests actually use sliding sync * Use UserFriendlyError * Remove empty constructor * Remove unrelated changes * Unused import * Fix import * Avoid moving import --------- Co-authored-by: Kegan Dougal <7190048+kegsay@users.noreply.github.com>

Switch sliding sync support to simplified sliding sync

65762c4

Experimental PR to test js-sdk with simlified sliding sync. This does not maintain support for regulaer sliding sync.

dbkr added a commit to element-hq/matrix-react-sdk that referenced this pull request Sep 12, 2024

Experimental SSS

df7bb61

Working branch to get SSS functional on element-web. Requires matrix-org/matrix-js-sdk#4400

dbkr mentioned this pull request Sep 12, 2024

Experimental SSS element-hq/matrix-react-sdk#36

Closed

4 tasks

kegsay added 6 commits September 13, 2024 09:36

Remove txn_id handling, ensure we always resend when req params change

2593998

Fix some tests

6fba79c

Fix remaining tests

e26e926

Mark TODOs on tests which need to die

c75c06a

Linting

7444094

Make comments lie less

bf7be48

kegsay added the T-Enhancement label Sep 13, 2024

void

ade2c86

github-actions bot deployed to PR Documentation Preview September 13, 2024 09:09 View deployment

kegsay added 2 commits September 13, 2024 11:26

Always sent full extension request

b8c3419

Fix test

85400e9

github-actions bot deployed to PR Documentation Preview September 13, 2024 10:29 View deployment

Remove usage of deprecated field

c44818f

github-actions bot deployed to PR Documentation Preview September 13, 2024 10:42 View deployment

Hopefully fix DM names

aeeb25f

kegsay added 3 commits September 16, 2024 08:38

Refactor how heroes are handled in Room

244ca62

Fix how heroes work

bd3f9f7

Linting

581b419

github-actions bot deployed to PR Documentation Preview September 16, 2024 08:18 View deployment

Ensure that when SSS omits heroes we don't forget we had heroes

39b4e9d

Otherwise when the room next appears the name/avatar reset to 'Empty Room' with no avatar.

github-actions bot deployed to PR Documentation Preview September 16, 2024 13:25 View deployment

Check the right flag when doing timeline trickling

11e7a3d

github-actions bot deployed to PR Documentation Preview September 16, 2024 13:31 View deployment

Also change when the backpagination token is set

511a873

github-actions bot deployed to PR Documentation Preview September 16, 2024 14:10 View deployment

Remove list ops and server-provided sort positions

181d786

SSS doesn't have them.

dbkr added 2 commits March 14, 2025 15:20

Make link work

793ae01

Nope, linter treats it as an unused import

d793a10

github-actions bot deployed to PR Documentation Preview March 14, 2025 14:24 View deployment

Add link the other way

7cca95a

github-actions bot deployed to PR Documentation Preview March 14, 2025 14:25 View deployment

dbkr requested a review from richvdh March 14, 2025 14:29

richvdh approved these changes Mar 18, 2025

View reviewed changes

dbkr and others added 2 commits March 18, 2025 14:44

Add more detail to doc

085a2d4

Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>

Remove unnecessary cast

bd6ba39

Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>

github-actions bot deployed to PR Documentation Preview March 18, 2025 14:46 View deployment

Remove length > 0 check

7e1eb16

as it wasn't really necessary and may cause heroes not to be cleared?

github-actions bot deployed to PR Documentation Preview March 18, 2025 15:05 View deployment

dbkr and others added 3 commits March 18, 2025 15:05

Doc params

5c44bbb

Remove unnecessary undefined comparison

5f0b2e3

Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>

Put the comparison back

0030998

as it's necessary to stop typescript complaining

github-actions bot deployed to PR Documentation Preview March 18, 2025 15:09 View deployment

Fix comment

707a7f5

github-actions bot deployed to PR Documentation Preview March 18, 2025 15:13 View deployment

Fix comment

532d885

github-actions bot deployed to PR Documentation Preview March 18, 2025 15:17 View deployment

Merge branch 'develop' into dbkr/sss

06b0fd4

github-actions bot deployed to PR Documentation Preview March 18, 2025 16:59 View deployment

dbkr added this pull request to the merge queue Mar 18, 2025

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 18, 2025

dbkr merged commit fd47a18 into develop Mar 18, 2025
30 checks passed

dbkr deleted the dbkr/sss branch March 18, 2025 17:23

FadhlanR mentioned this pull request Mar 20, 2025

Improve boot time by implementing sliding sync cardstack/boxel#2290

Merged

Uh oh!

Comments

Conversation

dbkr commented Sep 12, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

Uh oh!

DoM1niC commented Sep 13, 2024

Uh oh!

richvdh left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

richvdh Mar 18, 2025

Choose a reason for hiding this comment

Uh oh!

dbkr Mar 18, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

richvdh Mar 18, 2025

Choose a reason for hiding this comment

Uh oh!

dbkr Mar 18, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

richvdh Mar 18, 2025

Choose a reason for hiding this comment

Uh oh!

dbkr Mar 18, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

dbkr commented Mar 18, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

dbkr commented Sep 12, 2024 •

edited

Loading