chore(ffi): introduce AsyncRuntimeDropped helper
#4168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnjbvr
changed the title
AsyncRuntimeDropped helper
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4168 +/- ##
=======================================
Coverage 84.88% 84.88%
=======================================
Files 272 272
Lines 29133 29133
=======================================
Hits 24730 24730
Misses 4403 4403 ☔ View full report in Codecov by Sentry. |
This avoids proliferation of `ManuallyDrop` in the code base, by having a single type that's used for dropping under an async runtime.
bnjbvr
force-pushed
the
ffi/avoid-proliferation-of-manuallydrop
branch
from
1985150 to
a9b4867
Compare
|
Rebased, so ready for review. Still an open question if we want to share code between the two FFI crates, so it's possible to share this reusable thing with the crypto crate (that uses the same pattern twice). |
poljar
approved these changes
Nov 4, 2024
Hywan
approved these changes
Nov 4, 2024
| /// This is useful whenever such a data type may transitively call some | ||
| /// runtime's `block_on` function in their `Drop` impl (since we lack async drop | ||
| /// at the moment), like done in some `deadpool` drop impls. | ||
| pub(crate) struct AsyncRuntimeDropped<T>(ManuallyDrop<T>); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids proliferation of
ManuallyDropin the code base, by havinga single type that's used for dropping under an async runtime.
I actually saw three uses of
ManuallyDropon the FFI layer, but failed to notice that two of them were in the crypto FFI crate. Should I introduce a new FFI helper crate just for sharing this code across the two other crates?