fix(ui): Demote aggregation target not found log to TRACE level #4654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We encountered this warning a lot in the logs after upgrading the SDK today. My understanding is that this path is expected if the event is not yet in the timeline, so it's nothing to warn about. Signed-off-by: Kévin Commaille <[email protected]>
bnjbvr
approved these changes
Feb 11, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4654 +/- ##
=======================================
Coverage 85.68% 85.68%
=======================================
Files 292 292
Lines 33570 33570
=======================================
Hits 28763 28763
Misses 4807 4807 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We encountered this warning a lot in the logs after upgrading the SDK today. This comes from #4576.
My understanding is that this path is expected if the target event is not yet in the timeline, which can happen often when paginating backwards, so it's nothing to warn about.
cc @bnjbvr