sdk: improve logging for received history bundles #5866
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richvdh
force-pushed
the
rav/key_bundle_logging
branch
from
932f849 to
04efcc5
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5866 +/- ##
=======================================
Coverage 88.58% 88.58%
=======================================
Files 363 363
Lines 102782 102775 -7
Branches 102782 102775 -7
=======================================
- Hits 91048 91043 -5
+ Misses 7495 7494 -1
+ Partials 4239 4238 -1 ☔ View full report in Codecov by Sentry. |
CodSpeed Performance ReportMerging #5866 will not alter performanceComparing Summary
|
Hywan
approved these changes
Nov 14, 2025
Member
Hywan
left a comment
Hywan
left a comment
There was a problem hiding this comment.
Thanks!
A small suggestion, but I'm approving the patch ahead of time.
We had an instance where a user joined a room on Element X but did not download the key bundle, so let's add some logging to help figure out what was going on.
richvdh
force-pushed
the
rav/key_bundle_logging
branch
from
e3956ab to
49eae86
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had an instance where a user joined a room on Element X but did not download the key bundle, so let's add some logging to help figure out what was going on.