Skip to content

Comments

feat(qr-login): add additional QRCodeGrantLoginError enum values#6141

Open
hughns wants to merge 3 commits intomatrix-org:mainfrom
hughns:hughns/qr-code-grant-login-errors
Open

feat(qr-login): add additional QRCodeGrantLoginError enum values#6141
hughns wants to merge 3 commits intomatrix-org:mainfrom
hughns:hughns/qr-code-grant-login-errors

Conversation

@hughns
Copy link
Member

@hughns hughns commented Feb 9, 2026

On top of #6178

This adds additional QRCodeGrantLoginError enum values in the SDK crate and additional HumanQrGrantLoginError enum values in the FFI crate.

Most of the new values are assigned from what previous went to Unknown enum values.

The is one bugfix for where ::DeviceIDAlreadyInUse was erroneously being returned when the actually the device was not returned by the homeserver. This is now mapped to ::DeviceNotFound values.

  • Public API changes documented in changelogs (optional)

Signed-off-by:

@hughns hughns force-pushed the hughns/qr-code-grant-login-errors branch 3 times, most recently from 43f986b to a9787e9 Compare February 9, 2026 12:02
@codspeed-hq
Copy link

codspeed-hq bot commented Feb 9, 2026

Merging this PR will not alter performance

✅ 50 untouched benchmarks


Comparing hughns:hughns/qr-code-grant-login-errors (180a694) with main (3c13b3e)

Open in CodSpeed

@codecov
Copy link

codecov bot commented Feb 9, 2026

Codecov Report

❌ Patch coverage is 96.63963% with 29 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.89%. Comparing base (3c13b3e) to head (180a694).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...atrix-sdk/src/authentication/oauth/qrcode/grant.rs 96.74% 18 Missing and 10 partials ⚠️
.../matrix-sdk/src/authentication/oauth/qrcode/mod.rs 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6141      +/-   ##
==========================================
+ Coverage   89.84%   89.89%   +0.04%     
==========================================
  Files         365      365              
  Lines      100750   101567     +817     
  Branches   100750   101567     +817     
==========================================
+ Hits        90521    91305     +784     
- Misses       6692     6714      +22     
- Partials     3537     3548      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hughns hughns force-pushed the hughns/qr-code-grant-login-errors branch 3 times, most recently from ed264a0 to 2180251 Compare February 17, 2026 11:12
@hughns hughns marked this pull request as ready for review February 17, 2026 11:13
@hughns hughns requested a review from a team as a code owner February 17, 2026 11:13
@hughns hughns requested review from poljar and stefanceriu and removed request for a team February 17, 2026 11:13
@hughns hughns force-pushed the hughns/qr-code-grant-login-errors branch from 2180251 to 68974d6 Compare February 17, 2026 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants