feat(qr-login): add additional QRCodeGrantLoginError enum values#6141
Open
hughns wants to merge 3 commits intomatrix-org:mainfrom
Open
feat(qr-login): add additional QRCodeGrantLoginError enum values#6141hughns wants to merge 3 commits intomatrix-org:mainfrom
hughns wants to merge 3 commits intomatrix-org:mainfrom
Conversation
43f986b to
a9787e9
Compare
a9787e9 to
c76d52e
Compare
6 tasks
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #6141 +/- ##
==========================================
+ Coverage 89.84% 89.89% +0.04%
==========================================
Files 365 365
Lines 100750 101567 +817
Branches 100750 101567 +817
==========================================
+ Hits 90521 91305 +784
- Misses 6692 6714 +22
- Partials 3537 3548 +11 ☔ View full report in Codecov by Sentry. |
ed264a0 to
2180251
Compare
1 task
hughns
commented
Feb 17, 2026
2180251 to
68974d6
Compare
…nQrGrantLoginError::UnableToCreateDevice
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On top of #6178
This adds additional
QRCodeGrantLoginErrorenum values in the SDK crate and additionalHumanQrGrantLoginErrorenum values in the FFI crate.Most of the new values are assigned from what previous went to
Unknownenum values.The is one bugfix for where
::DeviceIDAlreadyInUsewas erroneously being returned when the actually the device was not returned by the homeserver. This is now mapped to::DeviceNotFoundvalues.Signed-off-by: