Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue where GCM pushkins behind proxy fail to start #408

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

devonh
Copy link
Contributor

@devonh devonh commented Feb 3, 2025

Fixes #407

There must be a running event loop at the time aiohttp.ClientSession is called.
With our existing code, this is not true. This PR changes that to ensure there is such an event loop.

asyncio.ensure_future will create, and start a new event loop if one has not already been started.

@devonh devonh requested a review from a team as a code owner February 3, 2025 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aiohttp version bump breaks Sygnal on startup
1 participant