Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: try loading kexi config default when --with-drt flag was used wi… #75

Closed
wants to merge 2 commits into from
Closed

WIP: try loading kexi config default when --with-drt flag was used wi… #75

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b695c34
WIP: try loading kexi config default when --with-drt flag was used wi…
tschlenther May 16, 2024
ffc80e5
KEXI only config
tschlenther May 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
150 changes: 150 additions & 0 deletions input/v3.1/kelheim-v3.1-config-kexi.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,150 @@
<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE config SYSTEM "http://www.matsim.org/files/dtd/config_v2.dtd">
<config>

<module name="controller">
<!-- add 'kexi' suffix' -->
<param name="runId" value="kelheim-v3.1-25pct-kexi"/>
<param name="outputDirectory" value="./output/output-kelheim-v3.1-25pct-kexi"/>
</module>

<!-- we need another vehicles file than in the base case because we need the drt vehicle type(s) -->
<module name="vehicles">
<param name="vehiclesFile" value="https://svn.vsp.tu-berlin.de/repos/public-svn/matsim/scenarios/countries/de/kelheim/kelheim-v3.0/input/kelheim-v3.0-vehicle-types-with-drt.xml"/>
</module>

<!-- we need another vehicles file than in the base case because we need the transit stops to be tagged for intermodal (drt) service-->
<module name="transit">
<param name="transitScheduleFile" value="https://svn.vsp.tu-berlin.de/repos/public-svn/matsim/scenarios/countries/de/kelheim/kelheim-v3.0/input/kelheim-v3.0-transitSchedule-with-intermodal-stops.xml.gz"/>
</module>

<module name="qsim">
<param name="simStarttimeInterpretation" value="onlyUseStarttime"/>
</module>

<!-- add drt to mode choie -->
<module name="subtourModeChoice">
<param name="modes" value="car,pt,bike,walk,ride,drt"/>
</module>

<module name="scoring">

<parameterset type="scoringParameters">
<!-- mode ASCs come from auto-calibration-->
<!-- For a bit of documentation on the non-zero marginal utilities per m, see the following link-->
<!-- https://svn.vsp.tu-berlin.de/repos/public-svn/matsim/scenarios/countries/de/kelheim/kelheim-v3.0/input/matsim-kelheim-v3.0-calibration-mode-parameters.pdf -->

<!-- drt stage activity types are added via code -->
<parameterset type="modeParams">
<param name="constant" value="2.45" />
<param name="marginalUtilityOfDistance_util_m" value="-2.5E-4" /> <!-- need this to fit the KEXI real data (Jan' 2022 - July 2023)-->
<param name="marginalUtilityOfTraveling_util_hr" value="0.0" />
<param name="mode" value="drt" />
<param name="monetaryDistanceRate" value="0.0" />
</parameterset>

</parameterset>
</module>

<module name="multiModeDrt">
<parameterset type="drt">
<param name="mode" value="drt"/>
<parameterset type="ExtensiveInsertionSearch" >
<param name="admissibleBeelineSpeedFactor" value="1.0" />
<param name="nearestInsertionsAtEndLimit" value="10" />
</parameterset>
<!-- If true, the startLink is changed to last link in the current schedule, so the taxi starts the next day at the link where it stopped operating the day before. False by default. -->
<param name="changeStartLinkToLastLinkInSchedule" value="false"/>
<!-- Defines the slope of the maxTravelTime estimation function (optimisation constraint), i.e. maxTravelTimeAlpha * estimated_drt_travel_time + maxTravelTimeBeta. Alpha should not be smaller than 1. -->
<param name="maxTravelTimeAlpha" value="1.5"/>
<!-- Defines the shift of the maxTravelTime estimation function (optimisation constraint), i.e. maxTravelTimeAlpha * estimated_drt_travel_time + maxTravelTimeBeta. Beta should not be smaller than 0. -->
<param name="maxTravelTimeBeta" value="1200.0"/>
<!-- Max wait time for the bus to come (optimisation constraint). -->
<param name="maxWaitTime" value="1200.0"/>
<!-- Maximum walk distance to next stop location in stationbased system. -->
<param name="maxWalkDistance" value="1500.0"/>
<param name="rejectRequestIfMaxWaitOrTravelTimeViolated" value="false" />
<!-- Operational Scheme, either door2door or stopbased. door2door by default -->
<param name="operationalScheme" value="stopbased"/>
<!-- Bus stop duration. -->
<param name="stopDuration" value="60.0"/>
<!-- Stop locations file (transit schedule format, but without lines) for DRT stops. Used only for the stopbased mode -->
<param name="transitStopFile" value="https://svn.vsp.tu-berlin.de/repos/public-svn/matsim/scenarios/countries/de/kelheim/kelheim-v3.0/input/kelheim-v3.0-drt-stops.xml"/>
<!-- Writes out detailed DRT customer stats in each iteration. True by default. -->
<param name="writeDetailedCustomerStats" value="true"/>
<parameterset type="zonalSystem">
<param name="zonesGeneration" value="ShapeFile"/>
<!--<param name="cellSize" value="200"/>-->
<param name="zonesShapeFile" value="https://svn.vsp.tu-berlin.de/repos/public-svn/matsim/scenarios/countries/de/kelheim/projects/KelRide/AVServiceAreas/input/shp/kelheim-v2.0-drtZonalAnalysisSystem.shp" />
</parameterset>
<!--<parameterset type="rebalancing">
<parameterset type="minCostFlowRebalancingStrategy">
<param name="targetAlpha" value="0.5"/>
<param name="targetBeta" value="0.5"/>
</parameterset>-->
<!-- </parameterset> -->
</parameterset>
</module>

<module name="dvrp" >
<!-- Mode of which the network will be used for routing vehicles, calculating travel times, etc. (fleet operator's perspective). If null, no mode filtering is done; the standard network (Scenario.getNetwork()) is used -->
<param name="networkModes" value="drt,av"/>

<!-- Used for estimation of travel times for VrpOptimizer by means of the exponential moving average. The weighting decrease, alpha, must be in (0,1]. We suggest small values of alpha, e.g. 0.05. The averaging starts from the initial travel time estimates. If not provided, the free-speed TTs is used as the initial estimates For more info see comments in: VrpTravelTimeEstimator, VrpTravelTimeModules, DvrpModule. -->
<param name="travelTimeEstimationAlpha" value="0.05" />
<parameterset type="travelTimeMatrix">
<param name="cellSize" value="200"/>
</parameterset>
</module>


<module name="swissRailRaptor">
<!-- Sets whether intermodal access and egress modes are selected by least cost (default) or randomly chosen out of the available access / egress modes. -->
<param name="intermodalAccessEgressModeSelection" value="CalcLeastCostModePerStop"/>
<!-- Possible values: Default, Individual -->
<param name="scoringParameters" value="Default"/>
<param name="transferPenaltyBaseCost" value="0.0"/>
<param name="transferPenaltyCostPerTravelTimeHour" value="0.0"/>
<param name="transferPenaltyMaxCost" value="Infinity"/>
<param name="transferPenaltyMinCost" value="-Infinity"/>
<!-- time deducted from transfer walk leg during transfers between pt legs in order to avoid missing a vehicle by a few seconds due to delays. -->
<param name="transferWalkMargin" value="5.0"/>
<!-- If true, SwissRailRaptor tries to detect when agents cannot board a vehicle in the previous iteration because it is already full and tries to find an alternative route instead. -->
<param name="useCapacityConstraints" value="false"/>
<param name="useModeMappingForPassengers" value="false"/>
<param name="useRangeQuery" value="false"/>
<param name="useIntermodalAccessEgress" value="true"/>
<parameterset type="intermodalAccessEgress">
<!-- Radius from the origin / destination coord in which transit stops are searched. Only if less than 2 transit stops are found the search radius is increased step-wise until the maximum search radius set in param radius is reached. -->
<param name="initialSearchRadius" value="10000.0"/>
<!-- If the mode is routed on the network, specify which linkId acts as access link to this stop in the transport modes sub-network. -->
<param name="linkIdAttribute" value="null"/>
<!-- Radius from the origin / destination coord in which transit stops are accessible by this mode. -->
<param name="maxRadius" value="10000.0"/>
<param name="mode" value="drt"/>
<param name="personFilterAttribute" value="null" />
<param name="personFilterValue" value="null" />
<!-- If less than 2 stops were found in initialSearchRadius take the distance of the closest transit stop and add this extension radius to search again.The search radius will not exceed the maximum search radius set in param radius. Default is 200 meters. -->
<param name="searchExtensionRadius" value="1000.0"/>
<!-- The share of the trip crowfly distance within which the stops for access and egress will be searched for. This is a harder constraint than initial search radius. Default is positive infinity. -->
<param name="shareTripSearchRadius" value="Infinity"/>
<!-- Name of the transit stop attribute used to filter stops that should be included in the set of potential stops for access and egress. The attribute should be of type String. 'null' disables the filter and all stops within the specified radius will be used. -->
<param name="stopFilterAttribute" value="allowDrtAccessEgress"/>
<!-- Only stops where the filter attribute has the value specified here will be considered as access or egress stops. -->
<param name="stopFilterValue" value="true"/>
</parameterset>
<parameterset type="intermodalAccessEgress">
<param name="initialSearchRadius" value="1500.0"/>
<param name="linkIdAttribute" value="null"/>
<param name="maxRadius" value="100000.0"/>
<param name="mode" value="walk"/>
<param name="personFilterAttribute" value="null"/>
<param name="personFilterValue" value="null"/>
<param name="searchExtensionRadius" value="1000.0"/>
<param name="shareTripSearchRadius" value="Infinity"/>
<param name="stopFilterAttribute" value="null"/>
<param name="stopFilterValue" value="null"/>
</parameterset>
</module>

</config>
57 changes: 37 additions & 20 deletions src/main/java/org/matsim/run/RunKelheimScenario.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@
import org.matsim.core.controler.Controler;
import org.matsim.core.router.AnalysisMainModeIdentifier;
import org.matsim.core.scoring.functions.ScoringParametersForPerson;
import org.matsim.core.utils.io.IOUtils;
import org.matsim.drtFare.KelheimDrtFareModule;
import org.matsim.extensions.pt.routing.ptRoutingModes.PtIntermodalRoutingModesConfigGroup;
import org.matsim.run.prepare.PrepareNetwork;
Expand Down Expand Up @@ -150,6 +151,42 @@ public static void addDrtCompanionParameters(DrtWithExtensionsConfigGroup drtWit
@Override
protected Config prepareConfig(Config config) {

if (drt) {
// config.addModule(new MultiModeDrtConfigGroup(DrtWithExtensionsConfigGroup::new));

if (!ConfigUtils.hasModule(config, MultiModeDrtConfigGroup.class)){
//the user did not provide a drt config, but used the --with-drt command line flag.
//Thus, we load the default KEXI config

//TODO instead of overriding entire config, load an extra config that does not contain duplicative stuff compared to base config.
//there is a draft for that but the utlility method overrides (deletes) all exisiting modeparams so it does not work as we need it.

config = ConfigUtils.loadConfig(
//config,
IOUtils.resolveFileOrResource(String.format("input/v%s/kelheim-v%s-25pct.kexi.config.xml", VERSION, VERSION)),
// IOUtils.resolveFileOrResource(String.format("input/v%s/kelheim-v%s-config-kexi.xml", VERSION, VERSION)),
new MultiModeDrtConfigGroup(DrtWithExtensionsConfigGroup::new));
}

MultiModeDrtConfigGroup multiModeDrtConfig = ConfigUtils.addOrGetModule(config, MultiModeDrtConfigGroup.class);

for (DrtConfigGroup drtConfigGroup : multiModeDrtConfig.getModalElements()) {
//only the KEXI (conventionally driven drt) should get companions
if (drtConfigGroup.getMode().equals(TransportMode.drt)) {
DrtWithExtensionsConfigGroup drtWithExtensionsConfigGroup = (DrtWithExtensionsConfigGroup) drtConfigGroup;
addDrtCompanionParameters(drtWithExtensionsConfigGroup);
}
}

ConfigUtils.addOrGetModule(config, DvrpConfigGroup.class);
DrtConfigs.adjustMultiModeDrtConfig(multiModeDrtConfig, config.scoring(), config.routing());
}

if (intermodal) {
ConfigUtils.addOrGetModule(config, PtIntermodalRoutingModesConfigGroup.class);
}


SnzActivities.addScoringParams(config);

config.controller().setOutputDirectory(sample.adjustName(config.controller().getOutputDirectory()));
Expand All @@ -172,26 +209,6 @@ protected Config prepareConfig(Config config) {
sw.defaultParams().mapZoomLevel = 11d;
sw.defaultParams().sampleSize = sample.getSample();

if (intermodal) {
ConfigUtils.addOrGetModule(config, PtIntermodalRoutingModesConfigGroup.class);
}

if (drt) {
config.addModule(new MultiModeDrtConfigGroup(DrtWithExtensionsConfigGroup::new));

MultiModeDrtConfigGroup multiModeDrtConfig = ConfigUtils.addOrGetModule(config, MultiModeDrtConfigGroup.class);

for (DrtConfigGroup drtConfigGroup : multiModeDrtConfig.getModalElements()) {
//only the KEXI (conventionally driven drt) should get companions
if (drtConfigGroup.getMode().equals(TransportMode.drt)) {
DrtWithExtensionsConfigGroup drtWithExtensionsConfigGroup = (DrtWithExtensionsConfigGroup) drtConfigGroup;
addDrtCompanionParameters(drtWithExtensionsConfigGroup);
}
}

ConfigUtils.addOrGetModule(config, DvrpConfigGroup.class);
DrtConfigs.adjustMultiModeDrtConfig(multiModeDrtConfig, config.scoring(), config.routing());
}

// Config is always needed
/* Informed-Mode-Choice
Expand Down
Loading