Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update typo in link to dev discussion #243

Merged
merged 2 commits into from
Dec 21, 2023

Conversation

krauspt
Copy link
Contributor

@krauspt krauspt commented Dec 16, 2023

What πŸ’»

  • I've found typo in link to developer discussion, this PR fixes the link. Maybe the target repo should be renamed, because the original typo is in the repository name.

Why βœ‹

  • To keep external resources approachable.

Evidence πŸ“·

No special evidence.

@krauspt krauspt requested a review from a team as a code owner December 16, 2023 16:27
@krauspt
Copy link
Contributor Author

krauspt commented Dec 21, 2023

@MexicanAce is there anything from my side that needs to be done?

@MexicanAce
Copy link
Collaborator

@krauspt Thanks for the ping (apologies, this got lost in my GitHub feed) and thank you for finding this!! Also just realized that the GitHub Discussions repo has a typo in it 🀦

I've kicked off the builds and will approve/merge here soon

Copy link
Collaborator

@MexicanAce MexicanAce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MexicanAce MexicanAce merged commit cc2ab1b into matter-labs:main Dec 21, 2023
9 checks passed
@MexicanAce
Copy link
Collaborator

We'll look into fixing the typo in the upstream repo, but that will require more changes as URL redirects are not supported by GitHub for repo renaming.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants