Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: release cross-rs dependency to use 0.2.4 #260

Merged
merged 1 commit into from
Feb 8, 2024
Merged

fix: release cross-rs dependency to use 0.2.4 #260

merged 1 commit into from
Feb 8, 2024

Conversation

dutterbutter
Copy link
Collaborator

@dutterbutter dutterbutter commented Feb 8, 2024 •
edited
Loading

What 💻

  • Use specific release tag for cross-rs

Why ✋

  • We were previously using main branch which had some issues

Evidence 📷

Include screenshots, screen recordings, or console output here demonstrating that your changes work as intended
Screenshot 2024-02-08 at 12 31 39 PM

@dutterbutter dutterbutter requested a review from a team as a code owner February 8, 2024 17:46
MexicanAce
MexicanAce approved these changes Feb 8, 2024
View reviewed changes
Copy link
Collaborator

@MexicanAce MexicanAce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, pending verification evidence

@dutterbutter dutterbutter merged commit a796760 into main Feb 8, 2024
11 checks passed
@dutterbutter dutterbutter deleted the db/fix-release-dep branch February 8, 2024 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MexicanAce MexicanAce MexicanAce approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dutterbutter @MexicanAce