Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: arg required name for emulate_evm #379

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

nbaztec
Copy link
Contributor

@nbaztec nbaztec commented Nov 5, 2024

What πŸ’»

  • Fix typo in arg name dev-system-contracts to dev_system_contracts

Why βœ‹

  • emulate_evm arg has a required defined for dev-system-contracts which leads to the following error when run via era_test_node run:
Command era_test_node: Argument or group 'dev-system-contracts' specified in 'requires*' for 'emulate_evm' does not exist

Evidence πŸ“·

image

@nbaztec nbaztec requested a review from a team as a code owner November 5, 2024 18:47
@dutterbutter
Copy link
Collaborator

@nbaztec are you sure? Works as intended for me and CI?

cargo build --release
   Compiling era_test_node v0.1.0-alpha.31 (/Users/dustinbrickwood/Documents/dev/zk/devx/era-test-node)
    Finished `release` profile [optimized] target(s) in 25.22s
./target/release/era_test_node run
19:27:52  INFO Starting network with chain id: L2ChainId(260)
19:27:52  INFO
19:27:52  INFO Rich Accounts
19:27:52  INFO =============
19:27:52  INFO Account #0: 0xBC989fDe9e54cAd2aB4392Af6dF60f04873A033A (1_000_000_000_000 ETH)
19:27:52  INFO Private Key: 0x3d3cbc973389cb26f657686445bcc75662b415b656078503592ac8c1abb8810e
19:27:52  INFO Mnemonic: mass wild lava ripple clog cabbage witness shell unable tribe rubber enter
19:27:52  INFO
19:27:52  INFO Account #1: 0x55bE1B079b53962746B2e86d12f158a41DF294A6 (1_000_000_000_000 ETH)
19:27:52  INFO Private Key: 0x509ca2e9e6acf0ba086477910950125e698d4ea70fa6f63e000c5a22bda9361c
19:27:52  INFO Mnemonic: crumble clutch mammal lecture lazy broken nominee visit gentle gather gym erupt
19:27:52  INFO
19:27:52  INFO Account #2: 0xCE9e6063674DC585F6F3c7eaBe82B9936143Ba6C (1_000_000_000_000 ETH)
19:27:52  INFO Private Key: 0x71781d3a358e7a65150e894264ccc594993fbc0ea12d69508a340bc1d4f5bfbc
19:27:52  INFO Mnemonic: illegal okay stereo tattoo between alien road nuclear blind wolf champion regular
19:27:52  INFO
19:27:52  INFO Account #3: 0xd986b0cB0D1Ad4CCCF0C4947554003fC0Be548E9 (1_000_000_000_000 ETH)
19:27:52  INFO Private Key: 0x379d31d4a7031ead87397f332aab69ef5cd843ba3898249ca1046633c0c7eefe
19:27:52  INFO Mnemonic: point donor practice wear alien abandon frozen glow they practice raven shiver
19:27:52  INFO
19:27:52  INFO Account #4: 0x87d6ab9fE5Adef46228fB490810f0F5CB16D6d04 (1_000_000_000_000 ETH)
19:27:52  INFO Private Key: 0x105de4e75fe465d075e1daae5647a02e3aad54b8d23cf1f70ba382b9f9bee839
19:27:52  INFO Mnemonic: giraffe organ club limb install nest journey client chunk settle slush copy
19:27:52  INFO
19:27:52  INFO Account #5: 0x78cAD996530109838eb016619f5931a03250489A (1_000_000_000_000 ETH)
19:27:52  INFO Private Key: 0x7becc4a46e0c3b512d380ca73a4c868f790d1055a7698f38fb3ca2b2ac97efbb
19:27:52  INFO Mnemonic: awful organ version habit giraffe amused wire table begin gym pistol clean
19:27:52  INFO
19:27:52  INFO Account #6: 0xc981b213603171963F81C687B9fC880d33CaeD16 (1_000_000_000_000 ETH)
19:27:52  INFO Private Key: 0xe0415469c10f3b1142ce0262497fe5c7a0795f0cbfd466a6bfa31968d0f70841
19:27:52  INFO Mnemonic: exotic someone fall kitten salute nerve chimney enlist pair display over inside
19:27:52  INFO
19:27:52  INFO Account #7: 0x42F3dc38Da81e984B92A95CBdAAA5fA2bd5cb1Ba (1_000_000_000_000 ETH)
19:27:52  INFO Private Key: 0x4d91647d0a8429ac4433c83254fb9625332693c848e578062fe96362f32bfe91
19:27:52  INFO Mnemonic: catch tragic rib twelve buffalo also gorilla toward cost enforce artefact slab
19:27:52  INFO
19:27:52  INFO Account #8: 0x64F47EeD3dC749d13e49291d46Ea8378755fB6DF (1_000_000_000_000 ETH)
19:27:52  INFO Private Key: 0x41c9f9518aa07b50cb1c0cc160d45547f57638dd824a8d85b5eb3bf99ed2bdeb
19:27:52  INFO Mnemonic: arrange price fragile dinner device general vital excite penalty monkey major faculty
19:27:52  INFO
19:27:52  INFO Account #9: 0xe2b8Cb53a43a56d4d2AB6131C81Bd76B86D3AFe5 (1_000_000_000_000 ETH)
19:27:52  INFO Private Key: 0xb0680d66303a0163a19294f1ef8c95cd69a9d7902a4aca99c05f3e134e68a11a
19:27:52  INFO Mnemonic: increase pulp sing wood guilt cement satoshi tiny forum nuclear sudden thank
19:27:52  INFO
19:27:52  INFO ========================================
19:27:52  INFO   Node is ready at 127.0.0.1:8011
19:27:52  INFO ========================================

@dutterbutter dutterbutter merged commit 9450384 into matter-labs:main Nov 5, 2024
10 checks passed
@nbaztec nbaztec deleted the fix-arg branch November 5, 2024 20:21
@nbaztec
Copy link
Contributor Author

nbaztec commented Nov 5, 2024

The assertion is a debug_assert, so it will not trigger in release build but is prevalent in tests and debug builds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants