feat: add anvil_mine_detailed
#460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dutterbutter
merged commit 928fea4
into
daniyar/manual-mine-non-empty-blocks
3 checks passed
itegulov
added a commit
that referenced
this pull request
Dec 3, 2024
* slightly reduce lock-related boilerplate * make sure system cotnracts are immutable * move `SystemContracts` to base node to minimize locking * make manual mining take txs from mempool * feat: add `anvil_mine_detailed` (#460) * fix `v` calculation for legacy txs * add `anvil_mine_detailed`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What 💻
Closes #454
The RPC is fairly straightforward but testing it required me to go on a rabbit hole that uncovered that alloy-zksync can't query transactions or hydrated blocks right now. popzxc/alloy-zksync#29 is what I arrived at while working on this, e2e-tests-rust has been updated to use that branch.
Why ✋
Feature parity with anvil