Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: adds abstract and abstract-testnet to named fork options #587

Merged
merged 3 commits into from
Feb 14, 2025
Merged

feat: adds abstract and abstract-testnet to named fork options #587

merged 3 commits into from
Feb 14, 2025

Conversation

dutterbutter
Copy link
Collaborator

What 💻

  • adds abstract and abstract-testnet to named fork options

Why ✋

  • Tired of having to type rpc url entirely

Evidence 📷

Include screenshots, screen recordings, or console output here demonstrating that your changes work as intended

@dutterbutter dutterbutter requested a review from a team as a code owner February 13, 2025 19:33
@dutterbutter dutterbutter enabled auto-merge (squash) February 13, 2025 20:14
@dutterbutter dutterbutter added the needs review 👓 PR requires a review label Feb 13, 2025
popzxc
popzxc approved these changes Feb 14, 2025
View reviewed changes
Copy link
Member

@popzxc popzxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we do this for other chains as well?

@dutterbutter dutterbutter merged commit 9774a3d into main Feb 14, 2025
13 checks passed
@dutterbutter dutterbutter deleted the db/add-abstract-to-named-forks branch February 14, 2025 06:17
@popzxc
Copy link
Member

popzxc commented Feb 14, 2025

Also BTW once we release it, we probably need to communicate with DevRel as e.g. "first-class citizen support for Abstract".

@zksync-era-bot zksync-era-bot mentioned this pull request Feb 14, 2025
Open
@dutterbutter
Copy link
Collaborator Author

@popzxc yes we should definitely add other chains as well, at least the ones we can support currently. Still need base token and validium support.

Will let devrel know before its released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@popzxc popzxc popzxc approved these changes

Assignees
No one assigned
Labels
needs review 👓 PR requires a review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dutterbutter @popzxc