-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(prover): Add gpu_checker binary #3573
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks overall good. Left a bunch of comments. I'm wondering, does it make to have 2 modes -- 1 in which you generate everything from scratch & one where you only run the GPU (with WVG already provided)? I'm thinking in situations when we want to give this to Google, we'd like it to be as small & fast as possible. But we also want it to be ergonomic for us, if we want to generate the WVG fast. WDYT?
Co-authored-by: EmilLuta <[email protected]>
Add README.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All in all looks fine for PoC to provide to google. I would've made a workflow where you can give either the circuits path or the WVG path. If you give circuits, you create WVG from it and pass it to circuit proving. If you give WVG, you just load it and do gpu proving.
Given it's meant to be a one use for GCP, I wouldn't invest more time into it.
Remove unneeded return.
What ❔
Add gpu_checker binary.
Why ❔
To quickly test if GPU is functioning properly.
Checklist
zkstack dev fmt
andzkstack dev lint
.