Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(prover): Add gpu_checker binary #3573

Open
wants to merge 23 commits into
base: main
Choose a base branch
from
Open

feat(prover): Add gpu_checker binary #3573

wants to merge 23 commits into from

Conversation

yorik
Copy link
Contributor

@yorik yorik commented Feb 6, 2025

What ❔

Add gpu_checker binary.

Why ❔

To quickly test if GPU is functioning properly.

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zkstack dev fmt and zkstack dev lint.

Copy link
Contributor

@EmilLuta EmilLuta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks overall good. Left a bunch of comments. I'm wondering, does it make to have 2 modes -- 1 in which you generate everything from scratch & one where you only run the GPU (with WVG already provided)? I'm thinking in situations when we want to give this to Google, we'd like it to be as small & fast as possible. But we also want it to be ergonomic for us, if we want to generate the WVG fast. WDYT?

docker/gpu-checker/Dockerfile Show resolved Hide resolved
prover/crates/bin/gpu_checker/src/main.rs Outdated Show resolved Hide resolved
prover/crates/bin/gpu_checker/src/main.rs Show resolved Hide resolved
prover/crates/lib/keystore/src/keystore.rs Outdated Show resolved Hide resolved
prover/crates/bin/gpu_checker/src/main.rs Outdated Show resolved Hide resolved
prover/crates/bin/gpu_checker/src/main.rs Outdated Show resolved Hide resolved
EmilLuta
EmilLuta previously approved these changes Feb 12, 2025
Copy link
Contributor

@EmilLuta EmilLuta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All in all looks fine for PoC to provide to google. I would've made a workflow where you can give either the circuits path or the WVG path. If you give circuits, you create WVG from it and pass it to circuit proving. If you give WVG, you just load it and do gpu proving.

Given it's meant to be a one use for GCP, I wouldn't invest more time into it.

prover/crates/bin/gpu_checker/src/main.rs Outdated Show resolved Hide resolved
prover/crates/bin/gpu_checker/src/main.rs Show resolved Hide resolved
prover/crates/bin/gpu_checker/src/main.rs Outdated Show resolved Hide resolved
@yorik yorik enabled auto-merge February 12, 2025 16:36
EmilLuta
EmilLuta previously approved these changes Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants