Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: V27 update #3580

Draft
wants to merge 36 commits into
base: main
Choose a base branch
from
Draft

feat!: V27 update #3580

wants to merge 36 commits into from

Conversation

0xVolosnikov
Copy link
Contributor

What ❔

Why ❔

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zkstack dev fmt and zkstack dev lint.

## What ❔

<!-- What are the changes this PR brings about? -->
<!-- Example: This PR adds a PR template to the repo. -->
<!-- (For bigger PRs adding more context is appreciated) -->

## Why ❔

<!-- Why are these changes done? What goal do they contribute to? What
are the principles behind them? -->
<!-- The `Why` has to be clear to non-Matter Labs entities running their
own ZK Chain -->
<!-- Example: PR templates ensure PR reviewers, observers, and future
iterators are in context about the evolution of repos. -->

## Is this a breaking change?
- [ ] Yes
- [ ] No

## Operational changes
<!-- Any config changes? Any new flags? Any changes to any scripts? -->
<!-- Please add anything that non-Matter Labs entities running their own
ZK Chain may need to know -->

## Checklist

<!-- Check your PR fulfills the following items. -->
<!-- For draft PRs check the boxes as you complete them. -->

- [ ] PR title corresponds to the body of PR (we generate changelog
entries from PRs).
- [ ] Tests for the changes have been added / updated.
- [ ] Documentation comments have been added / updated.
- [ ] Code has been formatted via `zkstack dev fmt` and `zkstack dev
lint`.
@0xVolosnikov
Copy link
Contributor Author

Legacy partial circuit wrappers should be removed (RamPermutationCircuit)

## What ❔

Fixes the upgrade workflow with new L1 contracts.

## Why ❔

The existing workflow doesn't work because of changes in
`ProposedUpgrade` (+ some stubs in the codebase).
Copy link
Contributor

Detected VM performance changes

Benchmark name Est. cycles Change in est. cycles
access_memory/legacy 13733203971 +8.6%
call_far/fast 3835770857 +442.7%
call_far/fast_no_sigs 3832667294 +444.6%
call_far/legacy 2536188958 +3.2%
decode_shl_sub/legacy 12868860583 +9.2%
deploy_simple_contract/fast 49607561 +3.9%
deploy_simple_contract/fast_no_sigs 46543476 +4.1%
deploy_simple_contract/legacy 56777165 +9.5%
event_spam/legacy 7681964534 +8.3%
finish_eventful_frames/legacy 3866315444 +4.7%
heap_read_write/legacy 11591550247 +9.4%
init/fast 14863553 +82.4%
init/fast_no_sigs 14898215 +82.0%
init/legacy 1923240 +41.4%
slot_hash_collision/legacy 13323289888 +8.9%
write_and_decode/legacy 13509344146 +8.7%

⚠ Detected differing instruction counts

Benchmark Old count New count
access_memory 4748374 4747811
call_far 319525 319502
decode_shl_sub 4748479 4747906
deploy_simple_contract 15422 15433
event_spam 2558512 2558215
finish_eventful_frames 786039 785964
heap_read_write 4252844 4252331
slot_hash_collision 4749388 4748825
write_and_decode 4749388 4748825

Changes in number of opcodes executed indicate that the gas price of the benchmark has changed, which causes it to run out of gas at a different time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants