Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tracing info to every function under compressor.rs #3585

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

heldersepu
Copy link

@heldersepu heldersepu commented Feb 8, 2025

What ❔

Simple change adding more logs to:
prover/crates/lib/keystore/src/compressor.rs

Why ❔

We ran into an error and all we got from the logs was this:

2025-02-01T08:31:54.644781Z INFO zksync_proof_fri_compressor::compressor: Started proof compression for L1 batch: L1BatchNumber(7)
thread 'tokio-runtime-worker' panicked at crates/lib/keystore/src/compressor.rs:115:39:
called Result::unwrap() on an Err value: Os { code: 2, kind: NotFound, message: "No such file or directory" }
2025-02-01T08:31:54.760894Z ERROR zksync_queued_job_processor: Error occurred while processing ProofCompressor job L1BatchNumber(7): "called Result::unwrap() on an Err value: Os { code: 2, kind: NotFound, message: "No such file or directory" }"
Compact raw CRS loading takes 0s

Clearly a file was missing message: "No such file or directory" but no hint at what file was missing `


After adding this we get a bit more in the logs enough to figure what file was missing:

2025-02-02T17:55:45.316365Z INFO zksync_proof_fri_compressor::compressor: Started proof compression for L1 batch: L1BatchNumber(7)
2025-02-02T17:55:45.350429Z INFO zksync_prover_keystore::compressor: Reading filepath "keys/setup/setup_compact.key"
2025-02-02T17:55:45.350552Z INFO zksync_prover_keystore::compressor: Reading filepath "/data/keys/plonk_setup_snark_data.bin"
thread 'tokio-runtime-worker' panicked at crates/lib/keystore/src/compressor.rs:115:39:
called Result::unwrap() on an Err value: Os { code: 2, kind: NotFound, message: "No such file or directory" }

Hopefully this change helps someone else save many hours of troubleshooting

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zkstack dev fmt and zkstack dev lint.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant