Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Fix proper namespace usage for IRSA #810

Merged
merged 2 commits into from
Jan 28, 2025
Merged

feat: Fix proper namespace usage for IRSA #810

merged 2 commits into from
Jan 28, 2025

Conversation

toninis
Copy link
Contributor

@toninis toninis commented Jan 28, 2025

Summary

Fix proper IRSA namespace service account relation since name var is not always the namespace that the app is deployed

Ticket Link

Release Note

@toninis toninis requested a review from a team as a code owner January 28, 2025 13:12
angeloskyratzakos
angeloskyratzakos previously approved these changes Jan 28, 2025
View reviewed changes
Copy link
Contributor

@angeloskyratzakos angeloskyratzakos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

angeloskyratzakos
angeloskyratzakos approved these changes Jan 28, 2025
View reviewed changes
Copy link
Contributor

@angeloskyratzakos angeloskyratzakos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stafot stafot merged commit 082c2f4 into master Jan 28, 2025
1 check passed
@stafot stafot deleted the fix/eks-customer-irsa branch January 28, 2025 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stafot stafot stafot approved these changes

@angeloskyratzakos angeloskyratzakos angeloskyratzakos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@toninis @stafot @angeloskyratzakos