Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MM-61123] Add diagnostics data to the Support Packet #36

Merged
merged 8 commits into from
Dec 10, 2024
Merged

[MM-61123] Add diagnostics data to the Support Packet #36

merged 8 commits into from
Dec 10, 2024

Conversation

hanzei
Copy link
Contributor

@hanzei hanzei commented Nov 13, 2024 •
edited
Loading

Summary

When a Support Packet gets generated, the plugin now includes diagnostics data via a diagnostics.yaml file into the Packet.

Example content of focalboard/diagnostics.yaml:

version: 9.0.1
total_boards: 1
active_cards: 8

Requires mattermost/mattermost#28833 on the server side.

See https://mattermost.atlassian.net/wiki/spaces/CLOUD/pages/3083108354/Diagnostics+data+from+Core+Plugins+to+the+Support+Packet for more context.

Ticket Link

https://mattermost.atlassian.net/browse/MM-61123

@hanzei hanzei changed the title [MM-61123] Update github.com/mattermost/mattermost/server/public [MM-61123] Add diagnostics data to the Support Packet Nov 13, 2024
@hanzei hanzei marked this pull request as ready for review November 13, 2024 09:50
@hanzei hanzei added 2: Dev Review Requires review by a core committer 3: QA Review Requires review by a QA tester labels Nov 13, 2024
hanzei
hanzei commented Nov 13, 2024
View reviewed changes
server/services/telemetry/mocks/ServerIface.go Outdated
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not used any longer

@hanzei hanzei force-pushed the MM-61123_support-packet branch from 4d49719 to fcedd84 Compare November 13, 2024 09:53
@hanzei hanzei force-pushed the MM-61123_support-packet branch from fcedd84 to 65d0836 Compare November 13, 2024 09:54
@harshilsharma63
Copy link
Member

cc @Rajat-Dabade

hanzei
hanzei commented Nov 13, 2024
View reviewed changes
@hanzei hanzei added the Work In Progress Not yet ready for review label Nov 13, 2024
@hanzei hanzei removed the Work In Progress Not yet ready for review label Nov 14, 2024
Rajat-Dabade
Rajat-Dabade approved these changes Nov 20, 2024
View reviewed changes
Copy link
Contributor

@Rajat-Dabade Rajat-Dabade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@hanzei hanzei removed the 2: Dev Review Requires review by a core committer label Nov 20, 2024
@hanzei
Copy link
Contributor Author

hanzei commented Dec 10, 2024

Per discussion with @raghavaggarwal2308, QA testing will happen post merge.

@hanzei hanzei removed the 3: QA Review Requires review by a QA tester label Dec 10, 2024
@hanzei hanzei added the 4: Reviews Complete All reviewers have approved the pull request label Dec 10, 2024
@hanzei hanzei merged commit 709f339 into main Dec 10, 2024
6 checks passed
@hanzei hanzei deleted the MM-61123_support-packet branch December 10, 2024 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wiggin77 wiggin77 wiggin77 approved these changes

@harshilsharma63 harshilsharma63 harshilsharma63 approved these changes

@Rajat-Dabade Rajat-Dabade Rajat-Dabade approved these changes

@AayushChaudhary0001 AayushChaudhary0001 Awaiting requested review from AayushChaudhary0001

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hanzei @harshilsharma63 @wiggin77 @Rajat-Dabade