Skip to content

Removed Metropolis font import#71

Merged
marianunez merged 2 commits intomainfrom
remove-fonts
Feb 12, 2025
Merged

Removed Metropolis font import#71
marianunez merged 2 commits intomainfrom
remove-fonts

Conversation

@marianunez
Copy link
Member

Summary

Boards was importing a different version of Metropolis that was causing conflict with the webapp imported fonts. We no longer need to import it in Boards as it will always run as a plugin and can expect it to have it loaded in the Webapp.

This import was from legacy Focalboard when running standalone.

Ticket Link

https://mattermost.atlassian.net/browse/MM-62774

@marianunez marianunez added 2: Dev Review Requires review by a core committer 3: QA Review Requires review by a QA tester labels Feb 7, 2025
Copy link

@yasserfaraazkhan yasserfaraazkhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • with plugins installed, the font appears correctly when we search with underscore.
  • Able to create boards, add comments to card, move cards.

Copy link
Contributor

@Rajat-Dabade Rajat-Dabade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@marianunez marianunez added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core committer labels Feb 12, 2025
@marianunez marianunez merged commit 1924c86 into main Feb 12, 2025
8 checks passed
@hanzei hanzei deleted the remove-fonts branch February 13, 2025 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3: QA Review Requires review by a QA tester 4: Reviews Complete All reviewers have approved the pull request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants