Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MM-571]: Fixed the issue of receiving Jira subscription after the channel is archived #1122

Merged
merged 4 commits into from
Mar 6, 2025

Conversation

Kshitij-Katiyar
Copy link
Contributor

@Kshitij-Katiyar Kshitij-Katiyar commented Sep 17, 2024

Summary

  • Fixed the issue of receiving the Jira subscription after the channel is archived

How to Test

  • Create a subscription in a channel and check if the subscription is working
  • Archive the channel
  • Try sending more subscription events
  • Unarchive the channel

Current behaviour

  • Subscription event notifications are received after the channel is archived

Updated behavior

  • No subscription event notification received after the channel is archived

Ticket Link:

Fixes #571

@wiggin77 wiggin77 added 2: Dev Review Requires review by a core committer 3: QA Review Requires review by a QA tester labels Sep 23, 2024
@raghavaggarwal2308 raghavaggarwal2308 removed the 2: Dev Review Requires review by a core committer label Nov 24, 2024
Copy link

@AayushChaudhary0001 AayushChaudhary0001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On testing this PR, it was found that the code changes are working fine except for the comment notifications which are not getting verified due to the issue #1175 . However, the PR is working fine for every other event.

@Kshitij-Katiyar
Copy link
Contributor Author

@AayushChaudhary0001 The issue is not related to this pr and also, and it is closed now.

Copy link

@AayushChaudhary0001 AayushChaudhary0001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, since the issue is not in the scope of this PR and is also closed. Rest everything is working fine.

@raghavaggarwal2308 raghavaggarwal2308 added 4: Reviews Complete All reviewers have approved the pull request and removed 3: QA Review Requires review by a QA tester labels Mar 6, 2025
@raghavaggarwal2308 raghavaggarwal2308 merged commit 09844a8 into master Mar 6, 2025
9 checks passed
@raghavaggarwal2308 raghavaggarwal2308 deleted the MM-571 branch March 6, 2025 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Jira subscriptions active after channel archived.
4 participants