Skip to content

Add global Parameters hotkey and hotkey label updates#260

Open
matijaerceg wants to merge 1 commit into
mausimus:masterfrom
matijaerceg:pr/hotkeys-clean
Open

Add global Parameters hotkey and hotkey label updates#260
matijaerceg wants to merge 1 commit into
mausimus:masterfrom
matijaerceg:pr/hotkeys-clean

Conversation

@matijaerceg

Copy link
Copy Markdown
image

What changed

  • Added a new Global Hotkeys menu entry: Parameters...
  • Added default Parameters hotkey: Ctrl+Shift+P
  • Wired Parameters into the existing global hotkey flow:
    • editable in Processing -> Global Hotkeys
    • persisted/restored with other hotkeys
    • registered/unregistered with global hotkey enable state
    • handled in WM_HOTKEY dispatch
  • Updated IDM_SHADER_PARAMETERS behavior to toggle the Parameters window (show/hide) instead of always showing
  • Updated Global Hotkeys submenu labels to show current assignment for each entry in parentheses, e.g. (Ctrl+Shift+P) or (None)
image

Validation

  • Built and ran on Windows (Release x64)
  • Verified Processing -> Global Hotkeys -> Parameters... can be edited and saved
  • Verified Ctrl+Shift+P toggles the Parameters window open/closed
  • Verified behavior when Global Hotkeys is enabled/disabled matches existing hotkeys
  • Verified clearing a hotkey shows (None) and disables that trigger
  • Verified assignments persist across app restart

Note: ShaderGlass/ShaderGlass.rc is UTF-16 (standard for this project), so GitHub may render it as binary.
Text diff for this file is:

@@ -56,6 +56,7 @@
             MENUITEM "Capture Cursor...",           ID_GLOBALHOTKEYS_CURSOR
             MENUITEM "Start/Stop...",               ID_GLOBALHOTKEYS_PAUSE
             MENUITEM "Toggle Menu...",              ID_GLOBALHOTKEYS_SHOWMENU
+            MENUITEM "Parameters...",               ID_GLOBALHOTKEYS_PARAMETERS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant