Telemetry and TelemetryServer improvements #2511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a regression with 1.2.0 regarding extra options.
|
Proto PR aiming at Should be ready to go. |
jonathanreeves
commented
Feb 12, 2025
julianoes
previously approved these changes
Feb 12, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: this is a re-creation of the now closed PR #2504. As far as I can tell, PR 2504 got closed because it was targeting a feature branch that was deleted. This now re-created PR is targeting
mainbut is otherwise the same.Overview
This PR does 3 things:
FixedwingMetricstelemetry object to include all fields that show up in the MAVLINK VFR_HUD message. The telemetry client handles the VFR_HUD message currently, translating it to aFixedwingMetricsstruct, but it only takes half the fields. This PR fills out the rest of the fields so the full message is available.TelemetryServerTelemetryServer. Note that the client already supports handling this message.Testing Done
Tested with a VTOL aircraft using MAVSDK as an autopilot, sending telemetry to QGroundControl. VFR and attitude messages are used to update the instrument panels and virtual horizon display. Hover taxi video here:
QGC-flight-smaller2.mp4
Notes and Caveats
There is a corresponding Proto PR based on Proto:main here: mavlink/MAVSDK-Proto#364
Unfortunately I am unable to get proto main to build against MAVSDK main, and I haven't had a chance to look into it. MAVSDK
mainis pinned to the proto submodule revision9a871c7b4ec53a753e9fc46e950c4433dc2d6bf7, which works fine, so I branched proto from this revision for my own testing. That is the branch that is being used in this PR currently.