src: lib: stream: Improve RTSP latency #426
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
is-live=true
inshmsrc
was adding ~1 frame of latency, while thesync=true
inshmsink
was adding more ~2.tested:
How to test:
Create a QrTimestamp 320x320@30fps RTSP stream as below:
![image](https://private-user-images.githubusercontent.com/5920286/350116444-d369857d-e563-4805-8e28-bcb4ef3b1f5d.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzg5Mjc1NTUsIm5iZiI6MTczODkyNzI1NSwicGF0aCI6Ii81OTIwMjg2LzM1MDExNjQ0NC1kMzY5ODU3ZC1lNTYzLTQ4MDUtOGUyOC1iY2I0ZWYzYjFmNWQucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIwNyUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMDdUMTEyMDU1WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9ZDg5YjBkMDVkOWFjMzA3NzM4NGRjNzA3ODdlMjY3MDM5ZTk4MmYzNTExNGFhNTdiMGM2NDgwMjBkMzIzZTJiZSZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.axMiazMGL0kP_6V3gMnbr622iZ_V4DBsOGwMX9NvkqI)
To receive it, run the following line:
Before this patch (master), the expected latency is ~100 ms.
After this patch it is ~34 ms (which is the same as the UDP)