Improve Redirect to WebRTC compatibility #459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| let pipeline = gst::parse::launch(&description) | ||
| .expect("Failed to create pipeline") | ||
| .downcast::<gst::Pipeline>() | ||
| .expect("Pipeline is not a valid gst::Pipeline"); | ||
|
|
||
| let typefinder = pipeline.by_name("typefinder")?; | ||
|
|
||
| let (tx, rx) = mpsc::channel(10); |
There was a problem hiding this comment.
A oneshot makes more sense here, no ?
There was a problem hiding this comment.
That was my first try, but oneshot requires T to impl copy :(
patrickelectric
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since WebRTC only works with a narrow option of stream formats, we are now re-encoding the RTP packages for Redirect streams, using the same strategy as for the Onvif sources.
An example is the stream from the Swell Pro. It's a 720p H264 stream but with an RTP incompatible with WebRTC.