CI: Create Continuous Prerelease #11929
Conversation
|
@mrpollo Thoughts on this? |
|
This should work, but we must test it as soon as possible. Unfortunately, we can't test until we merge. By the way, I'm also using the same action package for PX4 here: PX4/PX4-Autopilot#23703. |
| @@ -43,3 +43,11 @@ runs: | |||
| working-directory: ${{ runner.temp }}/shadow_build_dir/${{ inputs.source }} | |||
| run: aws s3 cp ${{ inputs.artifact_name }} s3://qgroundcontrol/latest/${{ inputs.artifact_name }} --acl public-read | |||
| shell: bash | |||
|
|
|||
| - name: Create Continuous Release | |||
| if: ${{ github.event_name != 'pull_request' && github.ref_name == 'master' && !github.event.pull_request.head.repo.fork }} | |||
There was a problem hiding this comment.
Did you test github.ref_name = 'master'? sometimes ref_name isn't what we want
There was a problem hiding this comment.
I would skip the fork conditional, I don't its needed
There was a problem hiding this comment.
Are you creating a release every time you push to master? Is this the desired behavior?
There was a problem hiding this comment.
Rather than every commit, should it be every night/week?
There was a problem hiding this comment.
Daily builds upload to S3 on every merge so seems like it should match that.
There was a problem hiding this comment.
Also seems like this is way ore important on automating Stables. This just kinda duplicates the S3 thing which is referenced by the docs. I guess some people go here to get releases though.
This should upload commits to master to a continuous release making it easy for people to download daily builds