dac, access profiles, tool groups docs#3738
Merged
Merged
Conversation
Contributor
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Workflows to automatically generate PRs for you. |
Contributor
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (12)
📒 Files selected for processing (28)
📝 WalkthroughSummary by CodeRabbit
WalkthroughThis PR substantially expands Bifrost Enterprise documentation by introducing three core governance feature pages (Access Profiles, MCP Tool Groups, Data Access Control), adding comprehensive migration guides from OSS to Enterprise, defining OpenAPI contracts for all new governance APIs, reorganizing enterprise marketing messaging with numbered feature sections, and marking WASM plugins as deprecated in favor of Go plugins. Navigation is consolidated in docs.json with new redirects for deprecated pages. ChangesEnterprise Documentation Restructuring and API Contracts
🎯 4 (Complex) | ⏱️ ~60 minutes Possibly Related PRs
Suggested Reviewers
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
|
akshaydeo
force-pushed
the
05-25-dac_access_profiles_tool_groups_docs
branch
from
44c7956 to
3d02f30
Compare
akshaydeo
force-pushed
the
05-25-dac_access_profiles_tool_groups_docs
branch
from
3d02f30 to
d07947d
Compare
akshaydeo
force-pushed
the
05-25-dac_access_profiles_tool_groups_docs
branch
from
d07947d to
737bca5
Compare
Contributor
Author
Merge activity
|
Contributor
Confidence Score: 4/5Safe to merge; all changes are documentation and OpenAPI spec additions with no runtime code affected. The two stale alt-text strings and the 200/201 status-code inconsistency on createRole are the only issues; neither prevents the docs from rendering correctly, but the status-code mismatch could trip up SDK generators. docs/openapi/paths/management/rbac.yaml (createRole response code) and docs/enterprise/access-profiles.mdx (two incorrect alt-text strings). Important Files Changed
Reviews (1): Last reviewed commit: "dac, access profiles, tool groups docs" | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Comment on lines
+89
to
+92
| <img | ||
| src="/media/access-profiles/new-access-profile.png" | ||
| alt="Access Profiles list page with table columns and create button" | ||
| /> |
Contributor
There was a problem hiding this comment.
Suggested change
| <img | |
| src="/media/access-profiles/new-access-profile.png" | |
| alt="Access Profiles list page with table columns and create button" | |
| /> | |
| <img | |
| src="/media/access-profiles/new-access-profile.png" | |
| alt="New Access Profile creation form showing name and description fields" | |
| /> |
Comment on lines
+103
to
+106
| <img | ||
| src="/media/access-profiles/access-profile-provider-config.png" | ||
| alt="Access Profiles list page with table columns and create button" | ||
| /> |
Contributor
There was a problem hiding this comment.
Suggested change
| <img | |
| src="/media/access-profiles/access-profile-provider-config.png" | |
| alt="Access Profiles list page with table columns and create button" | |
| /> | |
| <img | |
| src="/media/access-profiles/access-profile-provider-config.png" | |
| alt="Access Profile provider configuration showing allowed models, budget, and rate limit settings" | |
| /> |
Comment on lines
+34
to
+46
| responses: | ||
| '200': | ||
| description: Role created | ||
| content: | ||
| application/json: | ||
| schema: | ||
| $ref: '../../schemas/management/rbac.yaml#/RoleResponse' | ||
| '400': | ||
| $ref: '../../openapi.yaml#/components/responses/BadRequest' | ||
| '500': | ||
| $ref: '../../openapi.yaml#/components/responses/InternalError' | ||
|
|
||
| roles-by-id: |
Contributor
There was a problem hiding this comment.
createRole POST responds with 200 while both createAccessProfile and createMCPToolGroup — added in the same PR — respond with 201. REST convention reserves 201 Created for successful resource creation; using 200 here is inconsistent and may confuse SDK generators or clients that check for 201 after a POST.
Suggested change
| responses: | |
| '200': | |
| description: Role created | |
| content: | |
| application/json: | |
| schema: | |
| $ref: '../../schemas/management/rbac.yaml#/RoleResponse' | |
| '400': | |
| $ref: '../../openapi.yaml#/components/responses/BadRequest' | |
| '500': | |
| $ref: '../../openapi.yaml#/components/responses/InternalError' | |
| roles-by-id: | |
| responses: | |
| '201': | |
| description: Role created | |
| content: | |
| application/json: | |
| schema: | |
| $ref: '../../schemas/management/rbac.yaml#/RoleResponse' | |
| '400': | |
| $ref: '../../openapi.yaml#/components/responses/BadRequest' | |
| '500': | |
| $ref: '../../openapi.yaml#/components/responses/InternalError' | |
| roles-by-id: |
18 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Briefly explain the purpose of this PR and the problem it solves.
Changes
Type of change
Affected areas
How to test
Describe the steps to validate this change. Include commands and expected outcomes.
If adding new configs or environment variables, document them here.
Screenshots/Recordings
If UI changes, add before/after screenshots or short clips.
Breaking changes
If yes, describe impact and migration instructions.
Related issues
Link related issues and discussions. Example: Closes #123
Security considerations
Note any security implications (auth, secrets, PII, sandboxing, etc.).
Checklist
docs/contributing/README.mdand followed the guidelines