feat: add useSheetNavigation hook and SheetNavigationButtons component#3739
Conversation
📝 WalkthroughSummary by CodeRabbit
WalkthroughThis PR adds keyboard-driven sheet navigation by introducing a custom hook that registers ChangesSheet Navigation with Keyboard Shortcuts
Sequence DiagramsequenceDiagram
participant User
participant useSheetNavigation as Hook
participant SheetContent
participant SheetNavigationButtons
participant App as onNavigate Callback
User->>useSheetNavigation: Presses Arrow Up or K
useSheetNavigation->>useSheetNavigation: Check enabled && hasPrev
useSheetNavigation->>App: Call onNavigate("prev")
App->>App: Handle navigation
User->>SheetNavigationButtons: Click Prev Button
SheetNavigationButtons->>App: Call onNavigate("prev")
App->>App: Handle navigation
User->>User: Sheet opens
User->>SheetContent: Auto-focus event fires
SheetContent->>SheetContent: preventDefault()
SheetContent->>App: Call onOpenAutoFocus (if provided)
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
0235130 to
9973b3e
Compare
9973b3e to
b443ad2
Compare
c903978 to
0d8f218
Compare
b443ad2 to
dd253f3
Compare
0d8f218 to
6429b2e
Compare
6429b2e to
7d7b950
Compare
dd253f3 to
7f467dd
Compare
7d7b950 to
e745168
Compare
7f467dd to
23fe840
Compare
23fe840 to
e3d7333
Compare
e745168 to
5455304
Compare
5455304 to
08c7903
Compare
e3d7333 to
01edafd
Compare
useSheetNavigation hook and SheetNavigationButtons component
01edafd to
8a0a3b7
Compare
Confidence Score: 4/5The hook and button component are safe in isolation, but the global auto-focus suppression change in the shared SheetContent requires attention before merging. The unconditional e.preventDefault() in SheetContent.onOpenAutoFocus removes Radix UI's built-in focus management for every sheet in the application. This was added to support navigation sheets but affects all 15+ sheet consumers, meaning keyboard and screen-reader users must manually tab into any sheet that opens — a regression that goes beyond the intended scope of this feature. ui/components/ui/sheet.tsx — the global auto-focus suppression affects all sheets, not just navigation-aware ones. Important Files Changed
Reviews (2): Last reviewed commit: "feat: added useSheetNavigation hook" | Re-trigger Greptile |
2e139c9 to
fb08c09
Compare
e6a5076 to
1149f98
Compare
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@ui/components/sheetNavigationButtons.tsx`:
- Around line 46-55: Add data-testid attributes to the new navigation Button
elements in the SheetNavigationButtons component: for the previous button (the
Button with disabled={!hasPrev}, onClick={() => onNavigate("prev")},
aria-label={`Previous ${entityLabel}`} and child ChevronUp) add a unique
data-testid like "sheet-nav-prev" and for the corresponding next button (the
Button with disabled={!hasNext}, onClick={() => onNavigate("next")},
aria-label={`Next ${entityLabel}`} and child ChevronDown) add "sheet-nav-next"
so E2E tests can reliably target these interactive elements.
- Around line 22-24: Replace the unstable index-based key used in the keys.map
render inside sheetNavigationButtons.tsx: instead of key={i} on the
React.Fragment, construct a stable unique key from the shortcut item's
identifying properties (e.g., combine k.icon and k.label or another unique field
on the shortcut object) so the mapping in keys.map((k, i) => ...) uses that
deterministic key for the React.Fragment to ensure stable reconciliation.
In `@ui/components/ui/sheet.tsx`:
- Around line 106-109: The current inline handler always calls
e.preventDefault() in the onOpenAutoFocus prop, which disables Radix's default
autofocus even when no custom handler is provided; change the implementation in
the sheet component so you only call e.preventDefault() when a custom
onOpenAutoFocus handler exists — e.g., check if onOpenAutoFocus is truthy, then
run e.preventDefault() and invoke onOpenAutoFocus(e); otherwise do nothing so
Radix's default focus behavior remains intact.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: fc1f70e5-a34d-449a-a725-b17534ccc06e
📒 Files selected for processing (3)
ui/components/sheetNavigationButtons.tsxui/components/ui/sheet.tsxui/hooks/useSheetNavigation.ts
Merge activity
|
The base branch was changed.
…onent (#3739) ## Summary Introduces reusable keyboard-driven sheet navigation, allowing users to move between items in a sheet panel using arrow keys or vim-style `j`/`k` bindings. ## Changes - Added a `useSheetNavigation` hook that registers `up`/`k` (previous) and `down`/`j` (next) hotkeys via `react-hotkeys-hook`, conditionally enabled based on whether adjacent items exist. The hook returns shortcut key metadata for display in the UI. - Added a `SheetNavigationButtons` component that renders up/down chevron buttons with tooltips showing the associated keyboard shortcuts. Shortcuts are rendered as styled `<kbd>` elements, supporting both icon and label representations. ## Type of change - [ ] Bug fix - [x] Feature - [ ] Refactor - [ ] Documentation - [ ] Chore/CI ## Affected areas - [ ] Core (Go) - [ ] Transports (HTTP) - [ ] Providers/Integrations - [ ] Plugins - [x] UI (React) - [ ] Docs ## How to test ```sh cd ui pnpm i || npm i pnpm build || npm run build ``` Integrate `useSheetNavigation` and `SheetNavigationButtons` into a sheet component with a navigable list. Verify that: - The up/down buttons appear and are disabled when no previous/next item exists. - Pressing `↑`/`k` navigates to the previous item and `↓`/`j` navigates to the next. - Tooltips display the correct keyboard shortcut icons and labels. ## Screenshots/Recordings _Add before/after screenshots or clips of the navigation buttons and tooltips in action._ ## Breaking changes - [ ] Yes - [x] No ## Related issues _Link related issues here._ ## Security considerations None. ## Checklist - [ ] I read `docs/contributing/README.md` and followed the guidelines - [ ] I added/updated tests where appropriate - [ ] I updated documentation where needed - [ ] I verified builds succeed (Go and UI) - [ ] I verified the CI pipeline passes locally if applicable
## Summary This PR releases **core v1.5.14**, **framework v1.3.14**, **transports v1.5.6**, and bumps all dependent plugins to their respective `.14` patch versions. It delivers a broad set of new capabilities across MCP authentication, key rotation, OTel metrics, Bedrock/Anthropic compatibility, and UI improvements, alongside a number of targeted bug fixes and refactors. ## Changes - **Direct API Key Header** — Providers can now receive an API key passed directly via a request header (#3817) - **MCP Per-User Auth** — Introduced `MCPCredentialStore` abstraction, per-user MCP credential reconciliation, and a new per-user header auth type with lazy-auth submission flow (#3656, #3702, #3703, #3704, #3705) - **MCP TLS Configuration** — Added configurable TLS (`insecureSkipVerify`, `caCertPem`) for HTTP/SSE MCP client connections (#3779, #3783) - **MCP Sessions Management** — Filter, search, and pagination on the MCP sessions list API and table, plus a `can_reauth` identity gate (#3823, #3824, #3825) - **Key Rotation** — Keys now rotate on 401/402/403 responses; returns `502 upstream_credentials_exhausted` when all keys are permanently exhausted. Added `triggered_rotation` to `KeyAttemptRecord` and tightened `bifrost_key_rotation_events_total` semantics (#3430, #3491) - **OTel Metrics** — Added OTel spec-compatible metrics (backward compatible) with provider cache and semantic cache attributes in metrics export (#3865, #3816) - **Opus 4.8 Support** — System message handling and general compatibility for Opus 4.8 (#3868, #3878) - **Dimension Rankings** — New `GetDimensionRankings` API and dashboard tabs for team, customer, BU, and user rankings (#3766) - **Model Pricing Attributes** — `additional_attributes` field on model pricing rows with management API and UI editor (#3829) - **Prompt Cache Retention** — Added prompt cache retention parameter on responses requests (#3810) - **Tool Call Execution UI** — Inline tool-call execution, stop streaming, bulk execute/submit, and a redesigned tool-call UI (#3837, #3843) - **Sheet Navigation** — Prev/next keyboard navigation and URL state across virtual key, MCP client, and routing rule sheets (#3739, #3740, #3744, #3745) - **Bedrock Tool Name Truncation** — Truncate Bedrock function/tool names to the provider length limit - **Bedrock Guardrails** — Set guardrail config in Bedrock requests built from responses (#3862) - **Anthropic Tool Use** — Default `tool_use` input to `{}` when arguments are absent (#3880) - **Responses Streaming** — Fixed responses stream events (#3838) - **Compat Flow** — Fixed missing parameter parsing on the compat flow (#3881) - **Passthrough API Version** — Set a default API version in passthrough requests as a fallback (#3853) - **Virtual Key Updates** — Avoid overriding optional fields during virtual key update (#3855) - **User-Mode Flows** — Gate user-mode flows on caller `user_id`, skip temp token mint, and unify flow/credential kind filtering for pending flows (#3841, #3859) - **Partial Tool Calls** — Handle partial tool call execution failures and return successful results (#3849) - **URL Query Escaping** — Support escaped characters in URL query parameters (#3826) - **MCP Auth Errors** — Inline banner and retry support for MCP auth-required errors (#3856) - **Renamed Resolvers** — `staticHeadersResolver`/`serverOAuthResolver` renamed to `sharedHeadersResolver`/`sharedOAuthResolver` (#3840) - **Starlark Nested Tool Calls** — Exposed `RunWithPluginPipeline` on `ClientManager` and routed Starlark nested tool calls through the canonical plugin gate (#3794) - **Deferred-Fill OAuth Removed** — Removed deferred-fill user-mode OAuth flow support (#3839) - **Go 1.26.3** — Upgraded toolchain to Go 1.26.3 (#3782) ## Type of change - [x] Bug fix - [x] Feature - [x] Refactor - [ ] Documentation - [x] Chore/CI ## Affected areas - [x] Core (Go) - [x] Transports (HTTP) - [x] Providers/Integrations - [x] Plugins - [x] UI (React) - [ ] Docs ## How to test ```sh # Core/Transports go version # should report go1.26.3 go test ./... # UI cd ui pnpm i || npm i pnpm test || npm test pnpm build || npm run build ``` - Validate MCP per-user auth by configuring a per-user header auth type and confirming credentials are stored and reconciled on virtual key and MCP client changes. - Validate key rotation by triggering a 401/402/403 from an upstream provider and confirming rotation occurs; exhaust all keys and confirm a `502 upstream_credentials_exhausted` is returned. - Validate OTel metrics output includes `provider_cache` and `semantic_cache` attributes. - Validate Bedrock requests with tool names exceeding the provider limit are truncated correctly. - Validate Opus 4.8 system message handling by sending a request with a system message to an Opus 4.8 endpoint. ## Breaking changes - [x] Yes - [ ] No The deferred-fill user-mode OAuth flow has been removed (#3839). Any integrations relying on that flow must migrate to the new per-user credential store approach. The `staticHeadersResolver` and `serverOAuthResolver` identifiers have been renamed to `sharedHeadersResolver` and `sharedOAuthResolver` respectively (#3840); any direct references must be updated. ## Related issues #3817, #3656, #3702, #3703, #3704, #3705, #3779, #3783, #3823, #3824, #3825, #3430, #3491, #3865, #3816, #3868, #3878, #3766, #3829, #3810, #3837, #3843, #3739, #3740, #3744, #3745, #3862, #3880, #3838, #3881, #3853, #3855, #3841, #3859, #3849, #3826, #3856, #3840, #3794, #3839, #3782, #3724, #3814, #3836, #3869, #3886 ## Security considerations - MCP per-user credentials are stored via the new `MCPCredentialStore` abstraction; ensure the backing store is appropriately access-controlled and that credential values are encrypted at rest. - The direct API key header feature passes provider secrets via HTTP headers; ensure TLS is enforced on all ingress paths and that headers are not logged in plaintext. - User-mode flows are now gated on `caller user_id` and temp token minting is skipped where appropriate, reducing the surface for privilege escalation. - TLS configuration for MCP HTTP/SSE connections supports `insecureSkipVerify`; this should only be enabled in controlled environments. ## Checklist - [x] I read `docs/contributing/README.md` and followed the guidelines - [x] I added/updated tests where appropriate - [x] I updated documentation where needed - [x] I verified builds succeed (Go and UI) - [x] I verified the CI pipeline passes locally if applicable
## ✨ Features - **Direct API Key Header** - Pass a provider API key directly via request header (#3817) - **MCP Per-User Authentication** - New per-user header auth type with credential storage and lazy-auth submission flow (#3703, #3704, #3705) - **MCP TLS Configuration** - Configurable TLS (insecureSkipVerify, caCertPem) for HTTP/SSE MCP client connections (#3779, #3783) - **MCP Sessions Management** - Filter, search, and pagination on the MCP sessions list API and table, plus a can_reauth identity gate (#3823, #3824, #3825) - **Tool Call Execution UI** - Inline tool-call execution, stop streaming, bulk execute/submit, and a redesigned tool-call UI (#3837, #3843) - **Dimension Rankings Dashboard** - New dashboard tabs for team, customer, BU, and user rankings, backed by a GetDimensionRankings API (#3766) - **Model Pricing Attributes** - additional_attributes on model pricing rows with management API and UI editor (#3829) - **Prompt Cache Retention** - Prompt cache retention parameter on responses requests (#3810) - **Opus 4.8 Support** - System message handling and compatibility for Opus 4.8 (#3878, #3868) - **Key Rotation** - Rotate keys on 401/402/403 and return 502 upstream_credentials_exhausted when all keys are permanently dead (#3491) - **OTel Metrics** - OTel spec compatible metrics plus provider and semantic cache attributes in metrics export (#3865, #3816) - **Sheet Navigation** - Prev/next keyboard navigation and URL state across virtual key, MCP client, and routing rule sheets (#3739, #3740, #3744, #3745) - **Go 1.26.3** - Upgraded toolchain to Go 1.26.3 (#3782) ## 🐞 Fixed - **Bedrock Tool Names** - Truncate Bedrock function/tool names to the provider length limit - **Bedrock Guardrails** - Set guardrail config in Bedrock request built from responses (#3862) - **Anthropic Tool Use** - Default Anthropic tool_use input to {} when arguments are absent (#3880) - **Responses Streaming** - Fixed responses stream events (#3838) - **Compat Flow** - Fixed missing parameter parsing on the compat flow (#3881) - **Passthrough API Version** - Set a default API version in passthrough requests as a fallback (#3853) - **Virtual Key Updates** - Avoid overriding optional fields during virtual key update (#3855) - **User-Mode Flows** - Gate user-mode flows on caller user_id, skip temp token mint, and unify flow/credential kind filtering for pending flows (#3841, #3859) - **Partial Tool Calls** - Handle partial tool call execution failures and return successful results (#3849) - **URL Query Escaping** - Support escaped characters in URL query parameters (#3826) - **MCP Auth Errors** - Inline banner and retry support for MCP auth-required errors (#3856) - **JSON Editor Height** - Cap JSON editor max height at 400px in message views (#3842)

Summary
Introduces reusable keyboard-driven sheet navigation, allowing users to move between items in a sheet panel using arrow keys or vim-style
j/kbindings.Changes
useSheetNavigationhook that registersup/k(previous) anddown/j(next) hotkeys viareact-hotkeys-hook, conditionally enabled based on whether adjacent items exist. The hook returns shortcut key metadata for display in the UI.SheetNavigationButtonscomponent that renders up/down chevron buttons with tooltips showing the associated keyboard shortcuts. Shortcuts are rendered as styled<kbd>elements, supporting both icon and label representations.Type of change
Affected areas
How to test
Integrate
useSheetNavigationandSheetNavigationButtonsinto a sheet component with a navigable list. Verify that:↑/knavigates to the previous item and↓/jnavigates to the next.Screenshots/Recordings
Add before/after screenshots or clips of the navigation buttons and tooltips in action.
Breaking changes
Related issues
Link related issues here.
Security considerations
None.
Checklist
docs/contributing/README.mdand followed the guidelines