fix: mcp auth session UI improvements#3822
Conversation
|
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
Warning Review limit reached
More reviews will be available in 32 minutes and 33 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
📝 WalkthroughWalkthroughSessionsTable receives three localized cosmetic updates: the first column header is relabeled from "MCP Client" to "MCP server", the "needs_update" status badge switches from destructive to outlined red styling, and the access expiry placeholder for header rows changes from em-dash to hyphen for visual consistency. ChangesSessions Table Styling Updates
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Confidence Score: 5/5Safe to merge — all changes are cosmetic label and badge styling fixes with a consistent dependency version alignment. The UI changes are purely visual (column rename, badge styling, placeholder character), following the existing pattern set by the No files require special attention. Important Files Changed
Reviews (4): Last reviewed commit: "fix: mcp session ui fixes" | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
ui/app/workspace/mcp-sessions/views/sessionsTable.tsx (1)
131-131: 💤 Low valueTerminology mismatch: UI label vs. data model.
The header now displays "MCP server" while the underlying data field is
mcp_client(line 173), and code comments throughout refer to "MCP client". This creates a terminology inconsistency between the user-facing label and the implementation.If "MCP server" is the correct user-facing term (which it appears to be, since the MCP is the server that this system connects to), consider updating code comments and potentially the data model field name in a follow-up to maintain consistency, or document why the data model uses different terminology.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@ui/app/workspace/mcp-sessions/views/sessionsTable.tsx` at line 131, The TableHead text "MCP server" conflicts with the data field/identifier named mcp_client and comments referring to "MCP client"; update the code so UI label and implementation terminology match: either change the header text to "MCP client" to match the mcp_client field (TableHead) or rename the data field and related comments from mcp_client to mcp_server across the component (sessionsTable.tsx) and any column/renderer that uses mcp_client to preserve consistency; ensure you update any tooltip/comment near TableHead and the data mapping that reads mcp_client to use the chosen term.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@ui/app/workspace/mcp-sessions/views/sessionsTable.tsx`:
- Around line 285-291: Update the stale comment above the JSX return that
renders the Badge for the "needs_update" state to reflect that it uses an
outlined red variant (className "border-red-500 bg-red-100 ...") rather than the
destructive variant; mention the distinction between needs_update (outlined red,
user action required) and needs_reauth (uses variant="destructive", represents a
hard error) and remove the reference that they have the "same destructive
treatment." Reference the Badge rendering for the "needs_update" case so it's
clear which comment to change.
---
Nitpick comments:
In `@ui/app/workspace/mcp-sessions/views/sessionsTable.tsx`:
- Line 131: The TableHead text "MCP server" conflicts with the data
field/identifier named mcp_client and comments referring to "MCP client"; update
the code so UI label and implementation terminology match: either change the
header text to "MCP client" to match the mcp_client field (TableHead) or rename
the data field and related comments from mcp_client to mcp_server across the
component (sessionsTable.tsx) and any column/renderer that uses mcp_client to
preserve consistency; ensure you update any tooltip/comment near TableHead and
the data mapping that reads mcp_client to use the chosen term.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 2ad328df-883f-44ff-bd31-91e5f0c4e530
⛔ Files ignored due to path filters (1)
plugins/semanticcache/go.sumis excluded by!**/*.sum
📒 Files selected for processing (1)
ui/app/workspace/mcp-sessions/views/sessionsTable.tsx
Pratham-Mishra04
force-pushed
the
05-27-fix_mcp_session_ui_fixes
branch
from
d774b61 to
b87f181
Compare
Pratham-Mishra04
force-pushed
the
05-27-fix_mcp_session_ui_fixes
branch
from
b87f181 to
16ac7ee
Compare
Pratham-Mishra04
force-pushed
the
05-27-fix_mcp_session_ui_fixes
branch
from
16ac7ee to
f597d4d
Compare
Merge activity
|
This PR bumps the `bifrost/core` and `bifrost/plugins/mocker` dependency versions in the semantic cache plugin and makes minor UI fixes to the MCP sessions table for label accuracy and badge styling consistency. - Updated `bifrost/core` from `v1.5.12` to `v1.5.13` and `bifrost/plugins/mocker` from `v1.5.3` to `v1.5.13` in `plugins/semanticcache/go.sum` - Renamed the "MCP Client" column header to "MCP server" to better reflect what is being displayed - Replaced the destructive `Badge` variant for the "Needs update" status with an outlined badge using red border/background styling, distinguishing it visually from hard errors while still signaling user action is required - Changed the em dash (`—`) used as a placeholder in the access expiry column for header rows to a regular hyphen (`-`) for consistency with other placeholder values in the table - [x] Bug fix - [ ] Feature - [ ] Refactor - [ ] Documentation - [ ] Chore/CI - [ ] Core (Go) - [ ] Transports (HTTP) - [ ] Providers/Integrations - [x] Plugins - [x] UI (React) - [ ] Docs ```sh cd ui pnpm i || npm i pnpm test || npm test pnpm build || npm run build ``` Navigate to the MCP Sessions page and verify: - The first column header reads "MCP server" - Rows with a "Needs update" status display an outlined red badge rather than a solid destructive badge - Header rows in the access expiry column show a plain hyphen Before/after screenshots of the "Needs update" badge and column header rename recommended. - [ ] Yes - [x] No None. - [ ] I read `docs/contributing/README.md` and followed the guidelines - [ ] I added/updated tests where appropriate - [ ] I updated documentation where needed - [ ] I verified builds succeed (Go and UI) - [ ] I verified the CI pipeline passes locally if applicable
2 participants
Summary
This PR bumps the
bifrost/coreandbifrost/plugins/mockerdependency versions in the semantic cache plugin and makes minor UI fixes to the MCP sessions table for label accuracy and badge styling consistency.Changes
bifrost/corefromv1.5.12tov1.5.13andbifrost/plugins/mockerfromv1.5.3tov1.5.13inplugins/semanticcache/go.sumBadgevariant for the "Needs update" status with an outlined badge using red border/background styling, distinguishing it visually from hard errors while still signaling user action is required—) used as a placeholder in the access expiry column for header rows to a regular hyphen (-) for consistency with other placeholder values in the tableType of change
Affected areas
How to test
Navigate to the MCP Sessions page and verify:
Screenshots/Recordings
Before/after screenshots of the "Needs update" badge and column header rename recommended.
Breaking changes
Related issues
Security considerations
None.
Checklist
docs/contributing/README.mdand followed the guidelines