Skip to content

🐛 #294 - fix: darkmode now works in the theme designer#295

Merged
svenvandescheur merged 1 commit intomainfrom
issue/#294-dark-mode-theme-designer
Feb 26, 2026
Merged

🐛 #294 - fix: darkmode now works in the theme designer#295
svenvandescheur merged 1 commit intomainfrom
issue/#294-dark-mode-theme-designer

Conversation

@Xaohs
Copy link
Contributor

@Xaohs Xaohs commented Feb 24, 2026

closes #294
As discussed:

  • For now hardcoded (just like Purple Rain theme) but hopefully we can refactor this to be more dynamic in the future (and be able to view all our themes in storybook dynamically)

@codecov-commenter
Copy link

codecov-commenter commented Feb 24, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.81%. Comparing base (7090bc4) to head (b9a373c).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #295      +/-   ##
==========================================
- Coverage   91.86%   91.81%   -0.05%     
==========================================
  Files         200      200              
  Lines        8417     8417              
  Branches     1239     1237       -2     
==========================================
- Hits         7732     7728       -4     
- Misses        682      686       +4     
  Partials        3        3              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@svenvandescheur svenvandescheur force-pushed the issue/#294-dark-mode-theme-designer branch 2 times, most recently from 99a97f7 to 3291c66 Compare February 24, 2026 16:13
@Xaohs Xaohs force-pushed the issue/#294-dark-mode-theme-designer branch from 3291c66 to b9a373c Compare February 24, 2026 16:17
@svenvandescheur svenvandescheur merged commit dba444e into main Feb 26, 2026
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Theme Designer doesn't change to dark-mode

3 participants